chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h - Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address various nits from code review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_bar_constants.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h

index 97a7518e865bb48948aa0f18e7c6b140b5f1963f..cdae99d99ca367e91112b8064054d6c582846603 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h

@@ -23,11 +23,12 @@ const int kMaterialVisualHeightOffset = 2;

// new tab pages.

const int kNTPBookmarkBarPadding =

(chrome::kNTPBookmarkBarHeight -

- (chrome::kBookmarkBarHeight + kVisualHeightOffset)) / 2;

+ (chrome::kMinimumBookmarkBarHeight + kVisualHeightOffset)) /

+ 2;

// The height of buttons in the bookmark bar.

const int kBookmarkButtonHeight =

- chrome::kBookmarkBarHeight + kVisualHeightOffset;

+ chrome::kMinimumBookmarkBarHeight + kVisualHeightOffset;

// The height of buttons in a bookmark bar folder menu.

const CGFloat kBookmarkFolderButtonHeight = 24.0;