Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4528)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bar_constants.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address various nits from code review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/bookmarks/bookmark_bar_constants.h
diff --git a/chrome/browser/ui/bookmarks/bookmark_bar_constants.h b/chrome/browser/ui/bookmarks/bookmark_bar_constants.h
index a6c4e7bae77b9e820bbd8345200c859ae8de9c34..d6e35ead9bffdcc9893a3abe4a97bc109915c66d 100644
--- a/chrome/browser/ui/bookmarks/bookmark_bar_constants.h
+++ b/chrome/browser/ui/bookmarks/bookmark_bar_constants.h
@@ -10,19 +10,19 @@
namespace chrome {
// The height of Bookmarks Bar, when visible in "New Tab Page" mode.
-#if defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)
const int kNTPBookmarkBarHeight = 40;
-#endif
-// The height of Bookmarks Bar, when attached to the toolbar.
+// The minimum height of Bookmarks Bar, when attached to the toolbar. The
+// height of the toolbar may grow to more than this value if the embedded
+// views need more space, for example, when the font is larger than normal.
#if defined(OS_MACOSX)
// This is actually a little smaller than it should be (by |kVisualHeightOffset|
// points) because of the visual overlap with the main toolbar. When using this
// to compute values other than the actual height of the toolbar, be sure to add
// |kVisualHeightOffset|.
-const int kBookmarkBarHeight = 26;
+const int kMinimumBookmarkBarHeight = 26;
#elif defined(TOOLKIT_VIEWS)
-const int kBookmarkBarHeight = 28;
+const int kMinimumBookmarkBarHeight = 28;
#endif
} // namespace chrome
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698