chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm - Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call GetPreferredHeight() only once in GetPreferredSize() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bookmarks/bookmark_bar_constants.h ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

index 9743fcc952381c9a0dd046948e3819d56bde72e0..217c4fc5656f0e6dbfaca989298bc12c71951786 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

@@ -179,8 +179,8 @@ class BookmarkBarFolderControllerTest : public CocoaProfileTest {

// Make parent frame for bookmark bar then open it.

NSRect frame = [[test_window() contentView] frame];

frame = NSMakeRect(frame.origin.x,

- frame.size.height - chrome::kNTPBookmarkBarHeight,

- frame.size.width, chrome::kNTPBookmarkBarHeight);

+ frame.size.height - chrome::kNTPMinimumBookmarkBarHeight,

+ frame.size.width, chrome::kNTPMinimumBookmarkBarHeight);

NSView* fakeToolbarView = [[[NSView alloc] initWithFrame:frame]

autorelease];

[[test_window() contentView] addSubview:fakeToolbarView];