chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm - Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call GetPreferredHeight() only once in GetPreferredSize() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bookmarks/bookmark_bar_constants.h ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

index 9ba3378bc83cb2760e15a7bb1722fc311d3f6d64..9b90d07de2cba351a577ba60ddd493c6bdffadce 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

@@ -1022,14 +1022,13 @@ TEST_F(BookmarkBarControllerTest, BookmarkButtonSizing) {

for (NSButton* button in buttons) {

if (kIsModeMaterial) {

- EXPECT_FLOAT_EQ(

- (chrome::kBookmarkBarHeight +

- bookmarks::kMaterialVisualHeightOffset) -

- 2 * bookmarks::BookmarkVerticalPadding(),

- [button frame].size.height);

+ EXPECT_FLOAT_EQ((chrome::kMinimumBookmarkBarHeight +

+ bookmarks::kMaterialVisualHeightOffset) -

+ 2 * bookmarks::BookmarkVerticalPadding(),

+ [button frame].size.height);

} else {

EXPECT_FLOAT_EQ(

- (chrome::kBookmarkBarHeight + bookmarks::kVisualHeightOffset) -

+ (chrome::kMinimumBookmarkBarHeight + bookmarks::kVisualHeightOffset) -

2 * bookmarks::BookmarkVerticalPadding(),

[button frame].size.height);

}