Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2208783002: Make Tracing Service not use outgoing InterfaceProvider, update conventions (Closed)

Created:
4 years, 4 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), kalyank, qsr+mojo_chromium.org, rjkroege, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Tracing Service not use outgoing InterfaceProvider, update conventions R=rockot@chromium.org,tsepez@chromium.org Committed: https://crrev.com/97a8ae930e6e19506bf99b14d82ee4644cd7b29c Cr-Commit-Position: refs/heads/master@{#409660}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -860 lines) Patch
M ash/mus/window_manager_application.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/sysui_application.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/font_service/font_service_app.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_app.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/browser/browser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/browser/browser.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/views_examples.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/login/login.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/webtest/webtest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/webtest/webtest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M services/shell/standalone/context.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download
M services/shell/standalone/tracer.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M services/shell/standalone/tracer.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M services/tracing/BUILD.gn View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + services/tracing/data_sink.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + services/tracing/data_sink.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M services/tracing/main.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M services/tracing/public/cpp/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
A + services/tracing/public/cpp/provider.h View 1 2 3 chunks +26 lines, -19 lines 0 comments Download
A services/tracing/public/cpp/provider.cc View 1 2 1 chunk +149 lines, -0 lines 0 comments Download
D services/tracing/public/cpp/trace_provider_impl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D services/tracing/public/cpp/trace_provider_impl.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D services/tracing/public/cpp/tracing_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D services/tracing/public/cpp/tracing_impl.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M services/tracing/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/tracing/public/interfaces/tracing.mojom View 1 2 chunks +13 lines, -9 lines 0 comments Download
A services/tracing/recorder.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A services/tracing/recorder.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + services/tracing/service.h View 1 3 chunks +36 lines, -26 lines 0 comments Download
A + services/tracing/service.cc View 1 4 chunks +51 lines, -52 lines 0 comments Download
D services/tracing/trace_data_sink.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D services/tracing/trace_data_sink.cc View 1 1 chunk +0 lines, -32 lines 0 comments Download
M services/tracing/trace_recorder_impl.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
M services/tracing/trace_recorder_impl.cc View 1 1 chunk +0 lines, -31 lines 0 comments Download
D services/tracing/tracing_app.h View 1 chunk +0 lines, -82 lines 0 comments Download
D services/tracing/tracing_app.cc View 1 chunk +0 lines, -186 lines 0 comments Download
M services/ui/service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (17 generated)
Ben Goodger (Google)
rockot: * tsepez: *.mojom
4 years, 4 months ago (2016-08-03 17:26:26 UTC) #7
Tom Sepez
mojom lgtm.
4 years, 4 months ago (2016-08-03 20:52:02 UTC) #16
Ken Rockot(use gerrit already)
lgtm % redness (some stale header refs?)
4 years, 4 months ago (2016-08-03 21:00:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208783002/80001
4 years, 4 months ago (2016-08-03 21:09:12 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-03 23:27:51 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:29:50 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/97a8ae930e6e19506bf99b14d82ee4644cd7b29c
Cr-Commit-Position: refs/heads/master@{#409660}

Powered by Google App Engine
This is Rietveld 408576698