Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2209943002: Eliminate outgoing InterfaceProvider (Closed)

Created:
4 years, 4 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tracing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate outgoing InterfaceProvider R=rockot@chromium.org,tsepez@chromium.org Committed: https://crrev.com/a245c699d6ce7e19f17acfd4c42563bd22780b7e Cr-Commit-Position: refs/heads/master@{#409992}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -152 lines) Patch
M ash/mus/window_manager_application.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mash/app_driver/app_driver.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M mash/init/init.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M mash/session/session.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/connect_params.h View 2 chunks +0 lines, -8 lines 0 comments Download
M services/shell/public/cpp/connection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M services/shell/public/cpp/connector.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M services/shell/public/cpp/lib/connection_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/connection_impl.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.cc View 2 chunks +7 lines, -18 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M services/shell/public/cpp/lib/service_context.cc View 1 chunk +7 lines, -12 lines 0 comments Download
M services/shell/public/cpp/service_context.h View 1 chunk +1 line, -2 lines 0 comments Download
M services/shell/public/interfaces/connector.mojom View 2 chunks +0 lines, -7 lines 0 comments Download
M services/shell/public/interfaces/service.mojom View 1 chunk +7 lines, -12 lines 0 comments Download
M services/shell/service_manager.cc View 1 2 3 4 5 3 chunks +2 lines, -4 lines 0 comments Download
M services/shell/standalone/context.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/tests/connect/connect_test_app.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_app_a_manifest.json View 1 1 chunk +4 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_app_manifest.json View 1 1 chunk +4 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 1 2 5 chunks +21 lines, -65 lines 0 comments Download

Messages

Total messages: 44 (27 generated)
Ben Goodger (Google)
4 years, 4 months ago (2016-08-03 22:16:38 UTC) #3
Ken Rockot(use gerrit already)
LGTM LGTM LGTM LGTM
4 years, 4 months ago (2016-08-03 22:26:10 UTC) #4
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-03 22:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/1
4 years, 4 months ago (2016-08-04 01:14:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/201650)
4 years, 4 months ago (2016-08-04 01:32:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/1
4 years, 4 months ago (2016-08-04 02:00:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/201673)
4 years, 4 months ago (2016-08-04 02:15:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/1
4 years, 4 months ago (2016-08-04 02:53:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/212389)
4 years, 4 months ago (2016-08-04 03:07:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/40001
4 years, 4 months ago (2016-08-04 20:09:09 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/60001
4 years, 4 months ago (2016-08-04 21:10:29 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/255657)
4 years, 4 months ago (2016-08-04 22:27:10 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/80001
4 years, 4 months ago (2016-08-04 22:48:39 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/255693)
4 years, 4 months ago (2016-08-05 01:22:25 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209943002/100001
4 years, 4 months ago (2016-08-05 03:41:31 UTC) #40
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-05 05:06:32 UTC) #42
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 05:07:54 UTC) #44
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/a245c699d6ce7e19f17acfd4c42563bd22780b7e
Cr-Commit-Position: refs/heads/master@{#409992}

Powered by Google App Engine
This is Rietveld 408576698