Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2208653003: Disable testMultipleCrashMinidumps on Mac (Closed)

Created:
4 years, 4 months ago by nednguyen
Modified:
4 years, 4 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testMultipleCrashMinidumps on Mac BUG=634156 Committed: https://crrev.com/2635f5c8ce9322ecc49d2458824c261af847d20c Cr-Commit-Position: refs/heads/master@{#409655}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/core/minidump_unittest.py View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
aboxhall
https://codereview.chromium.org/2208653003/diff/1/tools/perf/core/minidump_unittest.py File tools/perf/core/minidump_unittest.py (right): https://codereview.chromium.org/2208653003/diff/1/tools/perf/core/minidump_unittest.py#newcode41 tools/perf/core/minidump_unittest.py:41: @decorators.Disabled('mac') # crbug.com/634156 Any issue with having both this ...
4 years, 4 months ago (2016-08-03 22:19:36 UTC) #4
aboxhall
lgtm
4 years, 4 months ago (2016-08-03 23:02:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208653003/1
4 years, 4 months ago (2016-08-03 23:10:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 23:14:44 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:16:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2635f5c8ce9322ecc49d2458824c261af847d20c
Cr-Commit-Position: refs/heads/master@{#409655}

Powered by Google App Engine
This is Rietveld 408576698