Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: tools/perf/core/minidump_unittest.py

Issue 2208653003: Disable testMultipleCrashMinidumps on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 6
7 from telemetry.testing import tab_test_case 7 from telemetry.testing import tab_test_case
8 from telemetry import decorators 8 from telemetry import decorators
9 from telemetry.core import util 9 from telemetry.core import util
10 10
(...skipping 20 matching lines...) Expand all
31 all_unsymbolized_after_symbolize_paths = \ 31 all_unsymbolized_after_symbolize_paths = \
32 self._browser.GetAllUnsymbolizedMinidumpPaths() 32 self._browser.GetAllUnsymbolizedMinidumpPaths()
33 logging.info('testSymbolizeMinidump: after symbolize all ' 33 logging.info('testSymbolizeMinidump: after symbolize all '
34 + 'unsymbolized paths: ' 34 + 'unsymbolized paths: '
35 + ''.join(all_unsymbolized_after_symbolize_paths)) 35 + ''.join(all_unsymbolized_after_symbolize_paths))
36 #self.assertTrue(len(all_unsymbolized_after_symbolize_paths) == 0) 36 #self.assertTrue(len(all_unsymbolized_after_symbolize_paths) == 0)
37 37
38 38
39 @decorators.Isolated 39 @decorators.Isolated
40 @decorators.Enabled('mac') 40 @decorators.Enabled('mac')
41 @decorators.Disabled('mac') # crbug.com/634156
aboxhall 2016/08/03 22:19:36 Any issue with having both this and Enabled, above
41 def testMultipleCrashMinidumps(self): 42 def testMultipleCrashMinidumps(self):
42 self._browser.tabs.New().Navigate('chrome://gpucrash', timeout=5) 43 self._browser.tabs.New().Navigate('chrome://gpucrash', timeout=5)
43 first_crash_path = self._browser.GetMostRecentMinidumpPath() 44 first_crash_path = self._browser.GetMostRecentMinidumpPath()
44 45
45 self.assertIsNotNone(first_crash_path) 46 self.assertIsNotNone(first_crash_path)
46 logging.info('testMultipleCrashMinidumps: first crash most recent path' 47 logging.info('testMultipleCrashMinidumps: first crash most recent path'
47 + first_crash_path) 48 + first_crash_path)
48 all_paths = self._browser.GetAllMinidumpPaths() 49 all_paths = self._browser.GetAllMinidumpPaths()
49 logging.info('testMultipleCrashMinidumps: first crash all paths: ' 50 logging.info('testMultipleCrashMinidumps: first crash all paths: '
50 + ''.join(all_paths)) 51 + ''.join(all_paths))
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 logging.info('testMultipleCrashMinidumps: after symbolize all paths: ' 94 logging.info('testMultipleCrashMinidumps: after symbolize all paths: '
94 + ''.join(after_symbolize_all_paths)) 95 + ''.join(after_symbolize_all_paths))
95 #self.assertEquals(len(after_symbolize_all_paths), 2) 96 #self.assertEquals(len(after_symbolize_all_paths), 2)
96 after_symbolize_all_unsymbolized_paths = \ 97 after_symbolize_all_unsymbolized_paths = \
97 self._browser.GetAllUnsymbolizedMinidumpPaths() 98 self._browser.GetAllUnsymbolizedMinidumpPaths()
98 logging.info('testMultipleCrashMinidumps: after symbolize all ' 99 logging.info('testMultipleCrashMinidumps: after symbolize all '
99 + 'unsymbolized paths: ' 100 + 'unsymbolized paths: '
100 + ''.join(after_symbolize_all_unsymbolized_paths)) 101 + ''.join(after_symbolize_all_unsymbolized_paths))
101 #self.assertEquals(after_symbolize_all_unsymbolized_paths, 102 #self.assertEquals(after_symbolize_all_unsymbolized_paths,
102 # [first_crash_path]) 103 # [first_crash_path])
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698