Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 2208613002: Remove MOJO_SHELL_CLIENT define. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tot-merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 #endif // defined(ENABLE_WEBRTC) 261 #endif // defined(ENABLE_WEBRTC)
262 262
263 #if defined(USE_AURA) 263 #if defined(USE_AURA)
264 #include "ui/aura/env.h" 264 #include "ui/aura/env.h"
265 #endif // defined(USE_AURA) 265 #endif // defined(USE_AURA)
266 266
267 #if !defined(OS_ANDROID) 267 #if !defined(OS_ANDROID)
268 #include "chrome/browser/usb/web_usb_detector.h" 268 #include "chrome/browser/usb/web_usb_detector.h"
269 #endif 269 #endif
270 270
271 #if defined(MOJO_SHELL_CLIENT) 271 #if defined(USE_AURA)
Ben Goodger (Google) 2016/08/04 14:43:36 So you're actually reducing the # of places this s
sadrul 2016/08/04 14:47:43 MOJO_SHELL_CLIENT is currently defined (and the de
272 #include "chrome/browser/lifetime/application_lifetime.h" 272 #include "chrome/browser/lifetime/application_lifetime.h"
273 #include "content/public/common/mojo_shell_connection.h" 273 #include "content/public/common/mojo_shell_connection.h"
274 #include "services/shell/runner/common/client_util.h" 274 #include "services/shell/runner/common/client_util.h"
275 #endif 275 #endif
276 276
277 #if defined(OS_WIN) || defined(OS_MACOSX) || \ 277 #if defined(OS_WIN) || defined(OS_MACOSX) || \
278 (defined(OS_LINUX) && !defined(OS_CHROMEOS)) 278 (defined(OS_LINUX) && !defined(OS_CHROMEOS))
279 #include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h " 279 #include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h "
280 #endif 280 #endif
281 281
(...skipping 935 matching lines...) Expand 10 before | Expand all | Expand 10 after
1217 // ChromeOS needs ResourceBundle::InitSharedInstance to be called before this. 1217 // ChromeOS needs ResourceBundle::InitSharedInstance to be called before this.
1218 browser_process_->PreCreateThreads(); 1218 browser_process_->PreCreateThreads();
1219 1219
1220 device::GeolocationProvider::SetGeolocationDelegate( 1220 device::GeolocationProvider::SetGeolocationDelegate(
1221 new ChromeGeolocationDelegate()); 1221 new ChromeGeolocationDelegate());
1222 1222
1223 return content::RESULT_CODE_NORMAL_EXIT; 1223 return content::RESULT_CODE_NORMAL_EXIT;
1224 } 1224 }
1225 1225
1226 void ChromeBrowserMainParts::PreMainMessageLoopRun() { 1226 void ChromeBrowserMainParts::PreMainMessageLoopRun() {
1227 #if defined(MOJO_SHELL_CLIENT) 1227 #if defined(USE_AURA)
1228 if (content::MojoShellConnection::GetForProcess() && shell::ShellIsRemote()) { 1228 if (content::MojoShellConnection::GetForProcess() && shell::ShellIsRemote()) {
1229 content::MojoShellConnection::GetForProcess()->SetConnectionLostClosure( 1229 content::MojoShellConnection::GetForProcess()->SetConnectionLostClosure(
1230 base::Bind(&chrome::SessionEnding)); 1230 base::Bind(&chrome::SessionEnding));
1231 } 1231 }
1232 #endif 1232 #endif
1233 TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreMainMessageLoopRun"); 1233 TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreMainMessageLoopRun");
1234 1234
1235 result_code_ = PreMainMessageLoopRunImpl(); 1235 result_code_ = PreMainMessageLoopRunImpl();
1236 1236
1237 for (size_t i = 0; i < chrome_extra_parts_.size(); ++i) 1237 for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
2068 chromeos::CrosSettings::Shutdown(); 2068 chromeos::CrosSettings::Shutdown();
2069 #endif // defined(OS_CHROMEOS) 2069 #endif // defined(OS_CHROMEOS)
2070 #endif // defined(OS_ANDROID) 2070 #endif // defined(OS_ANDROID)
2071 } 2071 }
2072 2072
2073 // Public members: 2073 // Public members:
2074 2074
2075 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) { 2075 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
2076 chrome_extra_parts_.push_back(parts); 2076 chrome_extra_parts_.push_back(parts);
2077 } 2077 }
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698