Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chromeos/login/auth/auth_status_consumer.h

Issue 2208583006: UMA for pin unlock success/failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/login/auth/auth_status_consumer.h
diff --git a/chromeos/login/auth/auth_status_consumer.h b/chromeos/login/auth/auth_status_consumer.h
index ad202a5c8a4bba857b7dc1cc2f72699c0e99ef90..40e351ee6722379fec51c9b6554082adbe2ae91d 100644
--- a/chromeos/login/auth/auth_status_consumer.h
+++ b/chromeos/login/auth/auth_status_consumer.h
@@ -40,7 +40,9 @@ class CHROMEOS_EXPORT AuthFailure {
};
explicit AuthFailure(FailureReason reason)
- : reason_(reason), error_(GoogleServiceAuthError::NONE) {
+ : is_pin_attempt_(false),
jdufault 2016/08/04 19:42:04 Initialize in declaration (line 107) instead of in
sammiequon 2016/08/05 01:46:00 Done.
+ reason_(reason),
+ error_(GoogleServiceAuthError::NONE) {
DCHECK(reason != NETWORK_AUTH_FAILED);
}
@@ -95,10 +97,14 @@ class CHROMEOS_EXPORT AuthFailure {
const GoogleServiceAuthError& error() const { return error_; }
const FailureReason& reason() const { return reason_; }
+ void SetIsPinAttempt(bool tried_pin) { is_pin_attempt_ = tried_pin; }
+ bool IsPinAttempt() const { return is_pin_attempt_; }
+
private:
AuthFailure(FailureReason reason, GoogleServiceAuthError error)
- : reason_(reason), error_(error) {}
+ : is_pin_attempt_(false), reason_(reason), error_(error) {}
+ bool is_pin_attempt_;
FailureReason reason_;
GoogleServiceAuthError error_;
};

Powered by Google App Engine
This is Rietveld 408576698