UMA for pin unlock success/failure.

chromeos/login/auth/auth_status_consumer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_LOGIN_AUTH_AUTH_STATUS_CONSUMER_H_
 #define CHROMEOS_LOGIN_AUTH_AUTH_STATUS_CONSUMER_H_
 
 #include <string>
 
 #include "base/logging.h"
@@ skipping 22 matching lines @@
     // value is synthesized by the ExistingUserController and passed to the
     // login_status_consumer_ in tests only. It is never generated or seen by
     // any of the other authenticator classes.
     TPM_ERROR,                   // Critical TPM error encountered.
     USERNAME_HASH_FAILED,        // Could not get username hash.
     FAILED_TO_INITIALIZE_TOKEN,  // Could not get OAuth2 Token,
     NUM_FAILURE_REASONS,         // This has to be the last item.
   };
 
   explicit AuthFailure(FailureReason reason)
-      : reason_(reason), error_(GoogleServiceAuthError::NONE) {
+      : is_pin_attempt_(false),

[jdufault, 2016/08/04 19:42:04]

Initialize in declaration (line 107) instead of in the ctor for constant values.

[sammiequon, 2016/08/05 01:46:00]

Done.

+        reason_(reason),
+        error_(GoogleServiceAuthError::NONE) {
     DCHECK(reason != NETWORK_AUTH_FAILED);
   }
 
   inline bool operator==(const AuthFailure& b) const {
     if (reason_ != b.reason_) {
       return false;
     }
     if (reason_ == NETWORK_AUTH_FAILED) {
       return error_ == b.error_;
     }
@@ skipping 34 matching lines @@
         return "OAuth2 token fetch failed.";
       default:
         NOTREACHED();
         return std::string();
     }
   }
 
   const GoogleServiceAuthError& error() const { return error_; }
   const FailureReason& reason() const { return reason_; }
 
+  void SetIsPinAttempt(bool tried_pin) { is_pin_attempt_ = tried_pin; }
+  bool IsPinAttempt() const { return is_pin_attempt_; }
+
  private:
   AuthFailure(FailureReason reason, GoogleServiceAuthError error)
-      : reason_(reason), error_(error) {}
+      : is_pin_attempt_(false), reason_(reason), error_(error) {}
 
+  bool is_pin_attempt_;
   FailureReason reason_;
   GoogleServiceAuthError error_;
 };
 
 // An interface that defines the callbacks for objects that the
 // Authenticator class will call to report the success/failure of
 // authentication for Chromium OS.
 class CHROMEOS_EXPORT AuthStatusConsumer {
  public:
   virtual ~AuthStatusConsumer() {}
   // The current login attempt has ended in failure, with error |error|.
   virtual void OnAuthFailure(const AuthFailure& error) = 0;
 
   // The current login attempt has succeeded for |user_context|.
   virtual void OnAuthSuccess(const UserContext& user_context) = 0;
   // The current guest login attempt has succeeded.
   virtual void OnOffTheRecordAuthSuccess() {}
   // The same password didn't work both online and offline.
   virtual void OnPasswordChangeDetected();
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_LOGIN_AUTH_AUTH_STATUS_CONSUMER_H_