UMA for pin unlock success/failure.

chrome/browser/chromeos/login/signin/device_id_browsertest.cc

Index: chrome/browser/chromeos/login/signin/device_id_browsertest.cc
diff --git a/chrome/browser/chromeos/login/signin/device_id_browsertest.cc b/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
index 4934033ee1cddc7a011282812a9a3b98a5aa8253..16847b3ea8eb3ae24293cb91e8ac36abbe6c3eae 100644
--- a/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
+++ b/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
@@ -113,12 +113,14 @@ class DeviceIDTest : public OobeBaseTest,
     WaitForSessionStart();
   }
 
-  void SignInOffline(const std::string& user_id, const std::string& password) {
+  void SignInOffline(const std::string& user_id,
+                     const std::string& password,
+                     bool using_pin) {

[jdufault, 2016/08/19 22:03:42]

If this takes a param it should pass it using the string. I'd eliminate the
function param all-together though.

[sammiequon, 2016/08/22 17:15:31]

Done.

     WaitForSigninScreen();
 
-    JS().ExecuteAsync(
-        base::StringPrintf("chrome.send('authenticateUser', ['%s', '%s'])",
-                           user_id.c_str(), password.c_str()));
+    JS().ExecuteAsync(base::StringPrintf(
+        "chrome.send('authenticateUser', ['%s', '%s', false])", user_id.c_str(),
+        password.c_str()));
     WaitForSessionStart();
   }
 
@@ -203,7 +205,7 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE_PRE_PRE_NewUsers) {
       GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail));
   EXPECT_FALSE(device_id.empty());
 
-  SignInOffline(kFakeUserEmail, kFakeUserPassword);
+  SignInOffline(kFakeUserEmail, kFakeUserPassword, false);
   CheckDeviceIDIsConsistent(AccountId::FromUserEmail(kFakeUserEmail),
                             kRefreshToken2);
 
@@ -261,7 +263,7 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE_Migration) {
 // state.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, Migration) {
   EXPECT_TRUE(GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail)).empty());
-  SignInOffline(kFakeUserEmail, kFakeUserPassword);
+  SignInOffline(kFakeUserEmail, kFakeUserPassword, false);
   CheckDeviceIDIsConsistent(AccountId::FromUserEmail(kFakeUserEmail),
                             kRefreshToken1);
 }
@@ -287,7 +289,7 @@ IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE_LegacyUsers) {
 // Tests that device ID has been generated after the first sign in.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, LegacyUsers) {
   EXPECT_TRUE(GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail)).empty());
-  SignInOffline(kFakeUserEmail, kFakeUserPassword);
+  SignInOffline(kFakeUserEmail, kFakeUserPassword, false);
   // Last param |auth_code| is empty, because we don't pass a device ID to GAIA
   // in this case.
   CheckDeviceIDIsConsistent(AccountId::FromUserEmail(kFakeUserEmail),