UMA for pin unlock success/failure.

chrome/browser/chromeos/login/signin/device_id_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 95 matching lines @@
     FakeGaia::MergeSessionParams params;
     params.email = user_id;
     params.refresh_token = refresh_token;
     fake_gaia_->UpdateMergeSessionParams(params);
     fake_gaia_->MapEmailToGaiaId(user_id, gaia_id);
 
     GetLoginDisplay()->ShowSigninScreenForCreds(user_id, password);
     WaitForSessionStart();
   }
 
-  void SignInOffline(const std::string& user_id, const std::string& password) {
+  void SignInOffline(const std::string& user_id,
+                     const std::string& password,
+                     bool using_pin) {

[jdufault, 2016/08/19 22:03:42]

If this takes a param it should pass it using the string. I'd eliminate the
function param all-together though.

[sammiequon, 2016/08/22 17:15:31]

Done.

     WaitForSigninScreen();
 
-    JS().ExecuteAsync(
-        base::StringPrintf("chrome.send('authenticateUser', ['%s', '%s'])",
-                           user_id.c_str(), password.c_str()));
+    JS().ExecuteAsync(base::StringPrintf(
+        "chrome.send('authenticateUser', ['%s', '%s', false])", user_id.c_str(),
+        password.c_str()));
     WaitForSessionStart();
   }
 
   void RemoveUser(const AccountId& account_id) {
     user_manager::UserManager::Get()->RemoveUser(account_id, this);
     user_removal_loop_.Run();
   }
 
  private:
   // user_manager::RemoveUserDelegate:
@@ skipping 64 matching lines @@
   CHECK_EQ(device_id, GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail)));
 }
 
 // Authenticate the first user offline and verify that device ID remains
 // the same.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE_PRE_PRE_NewUsers) {
   const std::string device_id =
       GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail));
   EXPECT_FALSE(device_id.empty());
 
-  SignInOffline(kFakeUserEmail, kFakeUserPassword);
+  SignInOffline(kFakeUserEmail, kFakeUserPassword, false);
   CheckDeviceIDIsConsistent(AccountId::FromUserEmail(kFakeUserEmail),
                             kRefreshToken2);
 
   // Verify that device ID remained the same after offline auth.
   CHECK_EQ(device_id, GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail)));
 }
 
 // Add the second user.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE_PRE_NewUsers) {
   WaitForSigninScreen();
@@ skipping 37 matching lines @@
   // Can't use SetKnownUserDeviceId here, because it forbids changing a device
   // ID.
   user_manager::known_user::SetStringPref(
       AccountId::FromUserEmail(kFakeUserEmail), "device_id", std::string());
 }
 
 // Tests that after the first sign in the device ID has been moved to the Local
 // state.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, Migration) {
   EXPECT_TRUE(GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail)).empty());
-  SignInOffline(kFakeUserEmail, kFakeUserPassword);
+  SignInOffline(kFakeUserEmail, kFakeUserPassword, false);
   CheckDeviceIDIsConsistent(AccountId::FromUserEmail(kFakeUserEmail),
                             kRefreshToken1);
 }
 
 // Set up a user that doesn't have a device ID.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, PRE_LegacyUsers) {
   SignInOnline(kFakeUserEmail, kFakeUserPassword, kRefreshToken1,
                kFakeUserGaiaId);
 
   PrefService* prefs =
       ProfileHelper::Get()
           ->GetProfileByUser(user_manager::UserManager::Get()->GetActiveUser())
           ->GetPrefs();
   EXPECT_TRUE(
       prefs->GetString(prefs::kGoogleServicesSigninScopedDeviceId).empty());
 
   // Can't use SetKnownUserDeviceId here, because it forbids changing a device
   // ID.
   user_manager::known_user::SetStringPref(
       AccountId::FromUserEmail(kFakeUserEmail), "device_id", std::string());
 }
 
 // Tests that device ID has been generated after the first sign in.
 IN_PROC_BROWSER_TEST_F(DeviceIDTest, LegacyUsers) {
   EXPECT_TRUE(GetDeviceId(AccountId::FromUserEmail(kFakeUserEmail)).empty());
-  SignInOffline(kFakeUserEmail, kFakeUserPassword);
+  SignInOffline(kFakeUserEmail, kFakeUserPassword, false);
   // Last param |auth_code| is empty, because we don't pass a device ID to GAIA
   // in this case.
   CheckDeviceIDIsConsistent(AccountId::FromUserEmail(kFakeUserEmail),
                             std::string());
 }
 
 }  // namespace chromeos