Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2208473008: In Isolate::Throw, call PredictExceptionCatcher only if necessary. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In Isolate::Throw, call PredictExceptionCatcher only if necessary. This reverts an unintended change that was part of my recent CL (https://codereview.chromium.org/2203803002). BUG= Committed: https://crrev.com/9ab456d65bf3b769ee54e416477db8353f869a3e Cr-Commit-Position: refs/heads/master@{#38334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/isolate.cc View 1 chunk +15 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
ptal
4 years, 4 months ago (2016-08-04 08:47:03 UTC) #2
Yang
On 2016/08/04 08:47:03, neis wrote: > ptal lgtm.
4 years, 4 months ago (2016-08-04 08:58:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208473008/1
4 years, 4 months ago (2016-08-04 08:59:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 09:23:17 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 09:24:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ab456d65bf3b769ee54e416477db8353f869a3e
Cr-Commit-Position: refs/heads/master@{#38334}

Powered by Google App Engine
This is Rietveld 408576698