[debug] Don't notify listener of exceptions internal to a desugaring.

[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
TBR=littledan@chromium.org
BUG=v8:5218
Committed: https://crrev.com/f813494fcc15497908ac5701e495a5bbc3cf9676
Cr-Commit-Position: refs/heads/master@{#38286}

[neis, 2016-08-02 15:44:37]

PTAL. This the old CL after removing the Turbofan changes, rebasing, and being
more careful in the isolate functions.  I'm not sure about
GetPromiseOnStackOnThrow, though.

[Yang, 2016-08-03 07:30:40]

On 2016/08/02 15:44:37, neis wrote:
> PTAL. This the old CL after removing the Turbofan changes, rebasing, and being
> more careful in the isolate functions.  I'm not sure about
> GetPromiseOnStackOnThrow, though.

lgtm!

[neis, 2016-08-03 08:58:57]

Description was changed from

==========
[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
BUG=v8:5218
==========

to

==========
[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
TBR=littledan@chromium.org
BUG=v8:5218
==========

[neis, 2016-08-03 08:59:43]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-03 08:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2203803002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-03 08:59:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 09:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:22:03]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11738)

[neis, 2016-08-03 09:29:38]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 09:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 09:37:17]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11741)

[neis, 2016-08-03 11:03:35]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-08-03 11:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 11:26:25]

Description was changed from

==========
[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
TBR=littledan@chromium.org
BUG=v8:5218
==========

to

==========
[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
TBR=littledan@chromium.org
BUG=v8:5218
==========

[commit-bot: I haz the power, 2016-08-03 11:26:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 11:27:57]

Description was changed from

==========
[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
TBR=littledan@chromium.org
BUG=v8:5218
==========

to

==========
[debug] Don't notify listener of exceptions internal to a desugaring.

In the parser, we desugar yield* with the help of a regular yield. One
particular implementation detail of this desugaring is that when the user calls
the generator's throw method, this throws an exception that we immediately
catch. This exception should not be visible to the user, but through Devtools'
"Pause on Caught Exceptions" feature it used to be.

This CL extends the type of catch predictions with a new value for such internal
exceptions and uses that for the offending try-catch statement in yield*.  It
instruments the debugger to _not_ trigger an exception event in that case.

R=yangguo@chromium.org
TBR=littledan@chromium.org
BUG=v8:5218

Committed: https://crrev.com/f813494fcc15497908ac5701e495a5bbc3cf9676
Cr-Commit-Position: refs/heads/master@{#38286}
==========

[commit-bot: I haz the power, 2016-08-03 11:27:58]

Patchset 2 (id:??) landed as
https://crrev.com/f813494fcc15497908ac5701e495a5bbc3cf9676
Cr-Commit-Position: refs/heads/master@{#38286}