Use smart pointers for class owned pointers under xfa/fde

Use smart pointers for class owned pointers under xfa/fde

Use smart pointer to replace raw pointer type for class
owned member variables so that memory management will
be easier.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/cddf8253692d3beaa97a502c8b60c1d18f81664a

[Wei Li, 2016-08-04 06:15:43]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 06:15:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 06:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 06:38:24]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-04 17:04:01]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-04 17:04:02]

pls review, thanks

[Lei Zhang, 2016-08-04 18:09:16]

Looking good.

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/cfde_txtedtbuf.cpp
File xfa/fde/cfde_txtedtbuf.cpp (right):

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/cfde_txtedtbuf....
xfa/fde/cfde_txtedtbuf.cpp:273:
m_pAllocator.reset(IFX_MemoryAllocator::Create(FX_ALLOCTYPE_Fixed,
Can we change IFX_MemoryAllocator::Create() to return a std::unique_ptr later?
There's only a few callers.

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/css/fde_cssstyl...
File xfa/fde/css/fde_cssstyleselector.cpp (right):

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/css/fde_cssstyl...
xfa/fde/css/fde_cssstyleselector.cpp:121: void
CFDE_CSSStyleSelector::SetFontMgr(IFGAS_FontMgr* pFontMgr) {
This is called right after creation. Merge into the ctor and make |m_pFontMgr| a
const pointer?

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/tto/fde_textout...
File xfa/fde/tto/fde_textout.cpp (right):

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/tto/fde_textout...
xfa/fde/tto/fde_textout.cpp:436: if (m_CharWidths.size() <
static_cast<size_t>(iSize))
We should make sure iType isn't negative, or change it to a size_t to avoid the
cast.

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/tto/fde_textout...
xfa/fde/tto/fde_textout.cpp:485: pTC->m_iCharWidth <= 0 ? 0 : pTC->m_iCharWidth;
std::max(pTC->m_iCharWidth, 0);

[Wei Li, 2016-08-04 21:20:08]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 21:20:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 21:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 21:35:32]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-04 21:42:25]

ptal, thanks

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/cfde_txtedtbuf.cpp
File xfa/fde/cfde_txtedtbuf.cpp (right):

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/cfde_txtedtbuf....
xfa/fde/cfde_txtedtbuf.cpp:273:
m_pAllocator.reset(IFX_MemoryAllocator::Create(FX_ALLOCTYPE_Fixed,
On 2016/08/04 18:09:15, Lei Zhang wrote:
> Can we change IFX_MemoryAllocator::Create() to return a std::unique_ptr later?
> There's only a few callers.

Done.

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/css/fde_cssstyl...
File xfa/fde/css/fde_cssstyleselector.cpp (right):

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/css/fde_cssstyl...
xfa/fde/css/fde_cssstyleselector.cpp:121: void
CFDE_CSSStyleSelector::SetFontMgr(IFGAS_FontMgr* pFontMgr) {
On 2016/08/04 18:09:15, Lei Zhang wrote:
> This is called right after creation. Merge into the ctor and make |m_pFontMgr|
a
> const pointer?

Done.

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/tto/fde_textout...
File xfa/fde/tto/fde_textout.cpp (right):

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/tto/fde_textout...
xfa/fde/tto/fde_textout.cpp:436: if (m_CharWidths.size() <
static_cast<size_t>(iSize))
On 2016/08/04 18:09:16, Lei Zhang wrote:
> We should make sure iType isn't negative, or change it to a size_t to avoid
the
> cast.

This was stemmed from signed FX_STRSIZE type problem. Fixed by adding an
assertion.

https://codereview.chromium.org/2208423002/diff/20001/xfa/fde/tto/fde_textout...
xfa/fde/tto/fde_textout.cpp:485: pTC->m_iCharWidth <= 0 ? 0 : pTC->m_iCharWidth;
On 2016/08/04 18:09:16, Lei Zhang wrote:
> std::max(pTC->m_iCharWidth, 0);

Done.

[Lei Zhang, 2016-08-04 21:53:56]

lgtm

https://codereview.chromium.org/2208423002/diff/40001/xfa/fde/css/fde_cssstyl...
File xfa/fde/css/fde_cssstyleselector.h (right):

https://codereview.chromium.org/2208423002/diff/40001/xfa/fde/css/fde_cssstyl...
xfa/fde/css/fde_cssstyleselector.h:92: CFDE_CSSStyleSelector(IFGAS_FontMgr*
pFontMgr);
explicit

[Wei Li, 2016-08-04 22:19:08]

thanks

https://codereview.chromium.org/2208423002/diff/40001/xfa/fde/css/fde_cssstyl...
File xfa/fde/css/fde_cssstyleselector.h (right):

https://codereview.chromium.org/2208423002/diff/40001/xfa/fde/css/fde_cssstyl...
xfa/fde/css/fde_cssstyleselector.h:92: CFDE_CSSStyleSelector(IFGAS_FontMgr*
pFontMgr);
On 2016/08/04 21:53:56, Lei Zhang wrote:
> explicit

Done.

[Wei Li, 2016-08-04 22:19:15]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-08-04 22:19:16]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2208423002/#ps60001
(title: "one more change")

[commit-bot: I haz the power, 2016-08-04 22:19:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 22:44:02]

Description was changed from

==========
Use smart pointers for class owned pointers under xfa/fde

Use smart pointer to replace raw pointer type for class
owned member variables so that memory management will
be easier.

BUG=pdfium:518
==========

to

==========
Use smart pointers for class owned pointers under xfa/fde

Use smart pointer to replace raw pointer type for class
owned member variables so that memory management will
be easier.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/cddf8253692d3beaa97a502c8b60c1d18f81...
==========

[commit-bot: I haz the power, 2016-08-04 22:44:03]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/cddf8253692d3beaa97a502c8b60c1d18f81...