xfa/fde/fde_gedevice.cpp - Issue 2208423002: Use smart pointers for class owned pointers under xfa/fde

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/fde_gedevice.cpp

Issue 2208423002: Use smart pointers for class owned pointers under xfa/fde (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: one more change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fde/fde_gedevice.cpp

diff --git a/xfa/fde/fde_gedevice.cpp b/xfa/fde/fde_gedevice.cpp

index 56f845c35bd23f0d0668bc7813dde0708e03b9a3..3612966e750a94e1432249ccea3edae6f56aa7a5 100644

--- a/xfa/fde/fde_gedevice.cpp

+++ b/xfa/fde/fde_gedevice.cpp

@@ -17,7 +17,6 @@ CFDE_RenderDevice::CFDE_RenderDevice(CFX_RenderDevice* pDevice,

FX_BOOL bOwnerDevice)

: m_pDevice(pDevice),

m_bOwnerDevice(bOwnerDevice),

- m_pCharPos(nullptr),

m_iCharCount(0) {

ASSERT(pDevice);

@@ -27,7 +26,6 @@ CFDE_RenderDevice::CFDE_RenderDevice(CFX_RenderDevice* pDevice,

}

CFDE_RenderDevice::~CFDE_RenderDevice() {

- FX_Free(m_pCharPos);

if (m_bOwnerDevice)

delete m_pDevice;

}

« no previous file with comments | « xfa/fde/fde_gedevice.h ('k') | xfa/fde/fde_render.h » ('j') | no next file with comments »