Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2208393002: ServiceWorker: Change DCHECK to CHECK for debugging (Closed)

Created:
4 years, 4 months ago by nhiroki
Modified:
4 years, 4 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Change DCHECK to CHECK for debugging BUG=619294 Committed: https://crrev.com/f65883a9c0e0412cf5fef1cf9c5f6091bbbfd325 Cr-Commit-Position: refs/heads/master@{#409751}

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert a part of changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/service_worker/service_worker_context_core.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
nhiroki
PTAL
4 years, 4 months ago (2016-08-04 03:51:50 UTC) #2
horo
https://codereview.chromium.org/2208393002/diff/1/content/browser/service_worker/service_worker_context_core.cc File content/browser/service_worker/service_worker_context_core.cc (left): https://codereview.chromium.org/2208393002/diff/1/content/browser/service_worker/service_worker_context_core.cc#oldcode558 content/browser/service_worker/service_worker_context_core.cc:558: // TODO(horo): If we will see crashes here, we ...
4 years, 4 months ago (2016-08-04 06:03:55 UTC) #3
nhiroki
PTAL https://codereview.chromium.org/2208393002/diff/1/content/browser/service_worker/service_worker_context_core.cc File content/browser/service_worker/service_worker_context_core.cc (left): https://codereview.chromium.org/2208393002/diff/1/content/browser/service_worker/service_worker_context_core.cc#oldcode558 content/browser/service_worker/service_worker_context_core.cc:558: // TODO(horo): If we will see crashes here, ...
4 years, 4 months ago (2016-08-04 06:28:19 UTC) #4
horo
lgtm
4 years, 4 months ago (2016-08-04 06:47:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208393002/20001
4 years, 4 months ago (2016-08-04 06:51:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/271551)
4 years, 4 months ago (2016-08-04 07:37:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208393002/20001
4 years, 4 months ago (2016-08-04 08:08:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 09:54:59 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 09:56:48 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f65883a9c0e0412cf5fef1cf9c5f6091bbbfd325
Cr-Commit-Position: refs/heads/master@{#409751}

Powered by Google App Engine
This is Rietveld 408576698