Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2208393002: ServiceWorker: Change DCHECK to CHECK for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert a part of changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index cd1abb63b7a6a3a410fc38fc54df8f1eeb731ef6..d787d5c1d9e71227ef5df1d4b66fd1540badb902 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -509,7 +509,9 @@ ServiceWorkerRegistration* ServiceWorkerContextCore::GetLiveRegistration(
void ServiceWorkerContextCore::AddLiveRegistration(
ServiceWorkerRegistration* registration) {
- DCHECK(!GetLiveRegistration(registration->id()));
+ // TODO(nhiroki): Change CHECK to DCHECK after https://crbug.com/619294 is
+ // fixed.
+ CHECK(!GetLiveRegistration(registration->id()));
live_registrations_[registration->id()] = registration;
if (observer_list_.get()) {
observer_list_->Notify(FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698