Use focused RenderWidgetHostImpl instead of TextInputManager::GetActiveWidget() to obtain TextSelec…

content/browser/renderer_host/render_widget_host_view_base.h

Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index 620b0eed3c5748f46b6c73c56423b4020d8087b5..002136d962137020b7c706b96b955c0a8bb5a8d5 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -64,6 +64,7 @@ class LatencyInfo;
 namespace content {
 class BrowserAccessibilityDelegate;
 class BrowserAccessibilityManager;
+class RenderWidgetHostImpl;
 class RenderWidgetHostViewBaseObserver;
 class SyntheticGesture;
 class SyntheticGestureTarget;
@@ -417,6 +418,10 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
   // |text_input_manager_|.
   TextInputManager* GetTextInputManager();
 
+  // This method returns the active widget form TextInputManager. If there are

[Charlie Reis, 2016/08/04 19:56:50]

s/form/from/

Also, do you mean "If there are no active widgets" for the focused case?

Can you add something to the comment about why focused makes sense as a fallback
when there is no active one?  I'm not sure I understand.

[EhsanK, 2016/08/04 22:29:55]

I removed this from patch. But why I had it:
GetActiveWidget() should either be nullptr or equal to the focused RWH. This is
not true though when we have race due to slow renderers but that is a problem
for another day I guess. 

When we implemented TextSelection tracking, the understanding I had was that all
text selection code on the browser side through SelectionChanged() runs only for
RWH which have <input>; which was incorrect in the case of X11 clipboard code.

After I saw this bug, my thoughts immediately went to using focused RWHV all
over the code. That adds complications as it does not interact well with
<webview>-browser plugin and also the const-ness issue.

+  // active widgets, this method will return the focused widget instead.
+  RenderWidgetHostImpl* ActiveOrFocusedWidget() const;
+
   // Whether this view is a popup and what kind of popup it is (select,
   // autofill...).
   blink::WebPopupType popup_type_;