Use focused RenderWidgetHostImpl instead of TextInputManager::GetActiveWidget() to obtain TextSelec…

content/browser/renderer_host/render_widget_host_view_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 46 matching lines @@
 class SurfaceHittestDelegate;
 }
 
 namespace ui {
 class LatencyInfo;
 }
 
 namespace content {
 class BrowserAccessibilityDelegate;
 class BrowserAccessibilityManager;
+class RenderWidgetHostImpl;
 class RenderWidgetHostViewBaseObserver;
 class SyntheticGesture;
 class SyntheticGestureTarget;
 class TextInputManager;
 class WebCursor;
 struct DidOverscrollParams;
 struct NativeWebKeyboardEvent;
 struct TextInputState;
 
 // Basic implementation shared by concrete RenderWidgetHostView subclasses.
@@ skipping 333 matching lines @@
   // null reference is obtained, its value is cached in |text_input_manager_|
   // and this view is registered with it. The RWHV will unregister from the
   // TextInputManager if it is destroyed or if the TextInputManager itself is
   // destroyed. The unregistration of the RWHV from TextInputManager is
   // necessary and must be done by explicitly calling
   // TextInputManager::Unregister.
   // It is safer to use this method rather than directly dereferencing
   // |text_input_manager_|.
   TextInputManager* GetTextInputManager();
 
+  // This method returns the active widget form TextInputManager. If there are

[Charlie Reis, 2016/08/04 19:56:50]

s/form/from/

Also, do you mean "If there are no active widgets" for the focused case?

Can you add something to the comment about why focused makes sense as a fallback
when there is no active one?  I'm not sure I understand.

[EhsanK, 2016/08/04 22:29:55]

I removed this from patch. But why I had it:
GetActiveWidget() should either be nullptr or equal to the focused RWH. This is
not true though when we have race due to slow renderers but that is a problem
for another day I guess. 

When we implemented TextSelection tracking, the understanding I had was that all
text selection code on the browser side through SelectionChanged() runs only for
RWH which have <input>; which was incorrect in the case of X11 clipboard code.

After I saw this bug, my thoughts immediately went to using focused RWHV all
over the code. That adds complications as it does not interact well with
<webview>-browser plugin and also the const-ness issue.

+  // active widgets, this method will return the focused widget instead.
+  RenderWidgetHostImpl* ActiveOrFocusedWidget() const;
+
   // Whether this view is a popup and what kind of popup it is (select,
   // autofill...).
   blink::WebPopupType popup_type_;
 
   // The background color of the web content.
   SkColor background_color_;
 
   // While the mouse is locked, the cursor is hidden from the user. Mouse events
   // are still generated. However, the position they report is the last known
   // mouse position just as mouse lock was entered; the movement they report
@@ skipping 48 matching lines @@
   base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
 
   base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_