Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2207973003: [DevTools] Removed InspectorTest.invokePageFunctionPromise from protocol tests (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed InspectorTest.invokePageFunctionPromise from protocol tests Replaced with Runtime.evaluateInPageAsync. BUG=632875 R=dgozman@chromium.org Committed: https://crrev.com/6d0a3d0010c22967f871db206600b40adda9de0c Cr-Commit-Position: refs/heads/master@{#409658}

Patch Set 1 #

Patch Set 2 : a #

Total comments: 2

Patch Set 3 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -91 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html View 1 2 2 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-infinite.html View 1 2 2 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-seek-past-end.html View 1 2 2 chunks +9 lines, -10 lines 0 comments Download

Depends on Patchset:

Issue 2207093002 Patch 60001

Messages

Total messages: 14 (7 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-03 18:25:01 UTC) #1
dgozman
https://codereview.chromium.org/2207973003/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html File third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html (right): https://codereview.chromium.org/2207973003/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html#newcode48 third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html:48: .then(() => InspectorTest.completeTest()); Don't do chain then() for synchronous ...
4 years, 4 months ago (2016-08-03 19:20:32 UTC) #4
kozy
all done. please take a look! https://codereview.chromium.org/2207973003/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html File third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html (right): https://codereview.chromium.org/2207973003/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html#newcode48 third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html:48: .then(() => InspectorTest.completeTest()); ...
4 years, 4 months ago (2016-08-03 20:35:23 UTC) #5
dgozman
lgtm
4 years, 4 months ago (2016-08-03 20:46:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207973003/40001
4 years, 4 months ago (2016-08-03 21:38:51 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 23:21:43 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:23:42 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6d0a3d0010c22967f871db206600b40adda9de0c
Cr-Commit-Position: refs/heads/master@{#409658}

Powered by Google App Engine
This is Rietveld 408576698