Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2207093002: [DevTools] InspectorTest.evaluateInPageAsync uses Runtime.evaluate (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] InspectorTest.evaluateInPageAsync uses Runtime.evaluate InspectorTest.evaluateInPageAsync uses Runtime.evaluate with awaitPromise flag. BUG=632875 R=dgozman@chromium.org Committed: https://crrev.com/ad603bf9b913f02ab9e81abffb2b630776f18c19 Cr-Commit-Position: refs/heads/master@{#409605}

Patch Set 1 #

Patch Set 2 : introduced evaluateInPageAsync #

Patch Set 3 : aligned with reference lusha's wisdom #

Patch Set 4 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 2 3 1 chunk +2 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html View 1 2 5 chunks +9 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-03 17:48:22 UTC) #1
dgozman
lgtm
4 years, 4 months ago (2016-08-03 18:59:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207093002/60001
4 years, 4 months ago (2016-08-03 19:01:12 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-03 20:12:49 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:14:47 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ad603bf9b913f02ab9e81abffb2b630776f18c19
Cr-Commit-Position: refs/heads/master@{#409605}

Powered by Google App Engine
This is Rietveld 408576698