Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2207603002: [Merge to M53] arc: Integration test for Arc package Chrome sync. (Closed)

Created:
4 years, 4 months ago by lgcheng
Modified:
4 years, 4 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, sync-reviews_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@M53_2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to M53] Integration test for Arc package Chrome sync. This Patch depends on: https://codereview.chromium.org/2205843004 BUG=631253 TEST=Pass added integration tests. Review-Url: https://codereview.chromium.org/2174753004 Cr-Commit-Position: refs/heads/master@{#409461} (cherry picked from commit 324b6cd92085c5dcce4a086aa613b643d886ff01) R=lhchavez@chromium.org, pavely@chromium.org, stevenjb@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4f7eed6eefe157b9deb1dad8e2fe39e06305867b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -22 lines) Patch
M chrome/browser/chromeos/profiles/profile_helper.h View 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/browser/sync/test/integration/sync_arc_package_helper.h View 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/browser/sync/test/integration/sync_arc_package_helper.cc View 1 chunk +244 lines, -0 lines 0 comments Download
A chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc View 1 chunk +178 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 12 chunks +6 lines, -21 lines 0 comments Download
M chrome/chrome_tests.gypi View 5 chunks +14 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
lgcheng
Hi Guys, PTAL at the patch. This is the M53-merge version of previous reviewed CL. ...
4 years, 4 months ago (2016-08-02 21:31:53 UTC) #3
Luis Héctor Chávez
lgtm
4 years, 4 months ago (2016-08-02 21:32:36 UTC) #4
pavely
lgtm
4 years, 4 months ago (2016-08-03 00:44:53 UTC) #6
lgcheng
Hi Steven, PTAL at the M53 merge patch. Original patch has landed into main branch.
4 years, 4 months ago (2016-08-05 16:41:33 UTC) #8
stevenjb
On 2016/08/05 16:41:33, lgcheng wrote: > Hi Steven, > > PTAL at the M53 merge ...
4 years, 4 months ago (2016-08-05 16:51:11 UTC) #9
lgcheng
On 2016/08/05 16:51:11, stevenjb wrote: > On 2016/08/05 16:41:33, lgcheng wrote: > > Hi Steven, ...
4 years, 4 months ago (2016-08-05 17:23:02 UTC) #10
Luis Héctor Chávez
4 years, 4 months ago (2016-08-08 20:45:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f7eed6eefe157b9deb1dad8e2fe39e06305867b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698