Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2205843004: [Merge to M53] arc: Initial implemetation of Chrome sync for Arc packages. (Closed)

Created:
4 years, 4 months ago by lgcheng
Modified:
4 years, 4 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, sadrul, Matt Giuca, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank, sync-reviews_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to M53] arc: Initial implemetation of Chrome sync for Arc packages. Sync protos is introduced in: https://codereview.chromium.org/2092893002/. BUG=631253 TEST=Dependent Patchset Review-Url: https://codereview.chromium.org/2106663004 Cr-Commit-Position: refs/heads/master@{#409437} (cherry picked from commit 50880b669bd0a6a13bb9030f3d4cfdd74fec2ef0) R=lhchavez@chromium.org, pavely@chromium.org, stevenjb@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/7ebbe53295b1500f5492184b90a4e2357584551e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+788 lines, -120 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_context_menu_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 8 chunks +27 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 10 chunks +47 lines, -42 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 1 chunk +11 lines, -14 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 29 chunks +11 lines, -47 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_syncable_service.h View 1 chunk +135 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 1 chunk +430 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_syncable_service_factory.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/arc/arc_package_syncable_service_factory.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M components/arc/instance_holder.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
lgcheng
Hi Guys, PTAL at the patch. This is the M53-merge version of previous reviewed CL. ...
4 years, 4 months ago (2016-08-02 21:32:40 UTC) #3
pavely
chrome/browser/sync lgtm
4 years, 4 months ago (2016-08-03 00:43:03 UTC) #6
lgcheng
Hi Steven, PTAL at the M53 merge patch. Original patch has landed into main branch.
4 years, 4 months ago (2016-08-05 16:41:18 UTC) #9
stevenjb
On 2016/08/05 16:41:18, lgcheng wrote: > Hi Steven, > > PTAL at the M53 merge ...
4 years, 4 months ago (2016-08-05 16:51:50 UTC) #10
Luis Héctor Chávez
lgtm
4 years, 4 months ago (2016-08-08 14:31:23 UTC) #11
Luis Héctor Chávez
4 years, 4 months ago (2016-08-08 20:37:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ebbe53295b1500f5492184b90a4e2357584551e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698