Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2207533002: [turbofan] Remove IfExceptionHint from exception projections. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove IfExceptionHint from exception projections. This completely removes translation of exception handler predictions from the graph IR. We now rely on the runtime using deoptimization infomation via {FrameSummary} for predictions in optimized code. R=bmeurer@chromium.org Committed: https://crrev.com/a4743baec153d6748dbdada4484f3fdd369ba7f2 Cr-Commit-Position: refs/heads/master@{#38250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -176 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 6 chunks +3 lines, -18 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +1 line, -15 lines 0 comments Download
M src/compiler/common-operator.cc View 4 chunks +1 line, -57 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +7 lines, -9 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 3 chunks +1 line, -19 lines 0 comments Download
M test/unittests/compiler/dead-code-elimination-unittest.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/tail-call-optimization-unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
Michael Starzinger
Benedikt: PTAL. Yang: FYI.
4 years, 4 months ago (2016-08-02 11:37:18 UTC) #2
Benedikt Meurer
Awesome. LGTM. Ship it!
4 years, 4 months ago (2016-08-02 11:40:30 UTC) #3
Yang
https://codereview.chromium.org/2207533002/diff/1/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/2207533002/diff/1/src/compiler/code-generator.cc#newcode234 src/compiler/code-generator.cc:234: table->SetReturnHandler(static_cast<int>(i), position, prediction); Do we still want to have ...
4 years, 4 months ago (2016-08-02 13:20:40 UTC) #4
Michael Starzinger
https://codereview.chromium.org/2207533002/diff/1/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/2207533002/diff/1/src/compiler/code-generator.cc#newcode234 src/compiler/code-generator.cc:234: table->SetReturnHandler(static_cast<int>(i), position, prediction); On 2016/08/02 13:20:40, Yang wrote: > ...
4 years, 4 months ago (2016-08-02 13:22:49 UTC) #5
Yang
On 2016/08/02 13:22:49, Michael Starzinger wrote: > https://codereview.chromium.org/2207533002/diff/1/src/compiler/code-generator.cc > File src/compiler/code-generator.cc (right): > > https://codereview.chromium.org/2207533002/diff/1/src/compiler/code-generator.cc#newcode234 ...
4 years, 4 months ago (2016-08-02 13:26:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207533002/20001
4 years, 4 months ago (2016-08-02 14:46:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 14:48:25 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 14:49:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4743baec153d6748dbdada4484f3fdd369ba7f2
Cr-Commit-Position: refs/heads/master@{#38250}

Powered by Google App Engine
This is Rietveld 408576698