Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2205893002: Remove catch prediction from handler table API. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-remove-catch-prediction
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove catch prediction from handler table API. This removes the ability to specify a catch prediction for exception handler tables that are based on return addresses. The encoding for handlers still looks the same to keep it in sync with tables based on ranges, just no payload is stored in the respective bits. R=yangguo@chromium.org Committed: https://crrev.com/13d2feefbaa293cf7e32126129ec1fa284b50b4a Cr-Commit-Position: refs/heads/master@{#38327}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Remove dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-02 14:46:24 UTC) #1
Yang
On 2016/08/02 14:46:24, Michael Starzinger wrote: lgtm.
4 years, 4 months ago (2016-08-04 07:28:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205893002/40001
4 years, 4 months ago (2016-08-04 07:54:53 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-04 08:19:25 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:22:33 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13d2feefbaa293cf7e32126129ec1fa284b50b4a
Cr-Commit-Position: refs/heads/master@{#38327}

Powered by Google App Engine
This is Rietveld 408576698