Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 220743003: Remove debugger_auto_break flag (Closed)

Created:
6 years, 8 months ago by yurys
Modified:
6 years, 8 months ago
Reviewers:
Yang, loislo
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove debugger_auto_break flag The flag was introduced to support console debugger in Chrome. That debugger was replaced by DevTools long time ago and the flag is always true now. BUG=None LOG=Y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M include/v8-debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
6 years, 8 months ago (2014-04-01 10:49:10 UTC) #1
Yang
On 2014/04/01 10:49:10, yurys wrote: lgtm.
6 years, 8 months ago (2014-04-01 11:16:29 UTC) #2
yurys
6 years, 8 months ago (2014-04-01 11:23:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698