Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/execution.cc

Issue 220743003: Remove debugger_auto_break flag (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « include/v8-debug.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "execution.h" 5 #include "execution.h"
6 6
7 #include "bootstrapper.h" 7 #include "bootstrapper.h"
8 #include "codegen.h" 8 #include "codegen.h"
9 #include "deoptimizer.h" 9 #include "deoptimizer.h"
10 #include "isolate-inl.h" 10 #include "isolate-inl.h"
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 } 512 }
513 513
514 514
515 bool StackGuard::IsDebugCommand() { 515 bool StackGuard::IsDebugCommand() {
516 ExecutionAccess access(isolate_); 516 ExecutionAccess access(isolate_);
517 return thread_local_.interrupt_flags_ & DEBUGCOMMAND; 517 return thread_local_.interrupt_flags_ & DEBUGCOMMAND;
518 } 518 }
519 519
520 520
521 void StackGuard::DebugCommand() { 521 void StackGuard::DebugCommand() {
522 if (FLAG_debugger_auto_break) { 522 ExecutionAccess access(isolate_);
523 ExecutionAccess access(isolate_); 523 thread_local_.interrupt_flags_ |= DEBUGCOMMAND;
524 thread_local_.interrupt_flags_ |= DEBUGCOMMAND; 524 set_interrupt_limits(access);
525 set_interrupt_limits(access);
526 }
527 } 525 }
528 #endif 526 #endif
529 527
530 void StackGuard::Continue(InterruptFlag after_what) { 528 void StackGuard::Continue(InterruptFlag after_what) {
531 ExecutionAccess access(isolate_); 529 ExecutionAccess access(isolate_);
532 thread_local_.interrupt_flags_ &= ~static_cast<int>(after_what); 530 thread_local_.interrupt_flags_ &= ~static_cast<int>(after_what);
533 if (!should_postpone_interrupts(access) && !has_pending_interrupts(access)) { 531 if (!should_postpone_interrupts(access) && !has_pending_interrupts(access)) {
534 reset_limits(access); 532 reset_limits(access);
535 } 533 }
536 } 534 }
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1014 if (stack_guard->IsInstallCodeRequest()) { 1012 if (stack_guard->IsInstallCodeRequest()) {
1015 ASSERT(isolate->concurrent_recompilation_enabled()); 1013 ASSERT(isolate->concurrent_recompilation_enabled());
1016 stack_guard->Continue(INSTALL_CODE); 1014 stack_guard->Continue(INSTALL_CODE);
1017 isolate->optimizing_compiler_thread()->InstallOptimizedFunctions(); 1015 isolate->optimizing_compiler_thread()->InstallOptimizedFunctions();
1018 } 1016 }
1019 isolate->runtime_profiler()->OptimizeNow(); 1017 isolate->runtime_profiler()->OptimizeNow();
1020 return isolate->heap()->undefined_value(); 1018 return isolate->heap()->undefined_value();
1021 } 1019 }
1022 1020
1023 } } // namespace v8::internal 1021 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8-debug.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698