Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2207343002: Update navigator.share API to match draft specs. (Closed)

Created:
4 years, 4 months ago by Sam McNally
Modified:
4 years, 4 months ago
Reviewers:
Mike West, Matt Giuca
CC:
blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update navigator.share API to match draft specs. This replaces the title and text string parameters with a ShareData dictionary optionally containing title, text and URL; the URL field is currently ignored. BUG=634198 Committed: https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9 Cr-Commit-Position: refs/heads/master@{#410297}

Patch Set 1 : #

Messages

Total messages: 21 (14 generated)
Sam McNally
4 years, 4 months ago (2016-08-04 07:36:26 UTC) #10
Matt Giuca
nice, lgtm
4 years, 4 months ago (2016-08-05 04:59:03 UTC) #13
Sam McNally
+mkwst
4 years, 4 months ago (2016-08-05 07:02:14 UTC) #15
Mike West
LGTM.
4 years, 4 months ago (2016-08-05 10:55:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207343002/40001
4 years, 4 months ago (2016-08-08 02:28:41 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-08-08 04:02:15 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 04:04:24 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9
Cr-Commit-Position: refs/heads/master@{#410297}

Powered by Google App Engine
This is Rietveld 408576698