Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: third_party/WebKit/Source/modules/webshare/NavigatorShare.idl

Issue 2207343002: Update navigator.share API to match draft specs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webshare/NavigatorShare.idl
diff --git a/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl b/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl
index 5408d3eb9a776023a92cea5ec9cfa35e89efe7a0..3fc019b9002ba3ec3b96ff8bed54bcae8c8d1dbd 100644
--- a/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl
+++ b/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl
@@ -7,12 +7,5 @@
[
RuntimeEnabled=WebShare,
] partial interface Navigator {
- // TODO(mgiuca): Take a ShareData object, not just these two fields (see
- // spec).
- [CallWith=ScriptState] Promise<void> share (
- DOMString title,
- DOMString text
- );
-
- // TODO(mgiuca): Add canShare method (see spec).
+ [CallWith=ScriptState] Promise<void> share(ShareData data);
};

Powered by Google App Engine
This is Rietveld 408576698