Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2207323002: [MD History] Factor out a common HistoryListBehavior. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Dirk Pranke, arv+watch_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Factor out a common HistoryListBehavior. This CL extracts a HistoryListBehavior that is used by the history-list and the history-grouped-list. The selection system has been refactored to accommodate different list structures. Using this behavior in the grouped history list means that it now implements selection and deletion. BUG=589357, 589363 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1a7fa0b24d413123832e2707adbc0266122a225f Cr-Commit-Position: refs/heads/master@{#411253}

Patch Set 1 #

Total comments: 22

Patch Set 2 : address comments, fix sorting bug #

Total comments: 5

Patch Set 3 : address comments #

Total comments: 10

Patch Set 4 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -122 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 3 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/grouped_list.html View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/grouped_list.js View 1 2 chunks +24 lines, -9 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 4 chunks +11 lines, -80 lines 0 comments Download
A chrome/browser/resources/md_history/history_list_behavior.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/md_history/history_list_behavior.js View 1 1 chunk +199 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 2 3 5 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_grouped_list_test.js View 1 2 chunks +110 lines, -6 lines 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 8 chunks +27 lines, -12 lines 0 comments Download
M chrome/test/data/webui/md_history/test_util.js View 1 1 chunk +34 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (16 generated)
calamity
Hoo-ee, here we go. PTAL (I'm Mr CL, look at me!)
4 years, 4 months ago (2016-08-04 04:00:27 UTC) #3
tsergeant
Huh. Where'd my friday morning go? https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/grouped_list.js File chrome/browser/resources/md_history/grouped_list.js (right): https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/grouped_list.js#newcode20 chrome/browser/resources/md_history/grouped_list.js:20: // history-list and ...
4 years, 4 months ago (2016-08-05 01:39:09 UTC) #4
calamity
https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/grouped_list.js File chrome/browser/resources/md_history/grouped_list.js (right): https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/grouped_list.js#newcode20 chrome/browser/resources/md_history/grouped_list.js:20: // history-list and into history-app. On 2016/08/05 01:39:09, tsergeant ...
4 years, 4 months ago (2016-08-09 02:56:01 UTC) #10
tsergeant
https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/list_container.js File chrome/browser/resources/md_history/list_container.js (right): https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/list_container.js#newcode88 chrome/browser/resources/md_history/list_container.js:88: this.$.content.selectedItem.unselectAllItems(count); On 2016/08/09 02:56:00, calamity wrote: > On 2016/08/05 ...
4 years, 4 months ago (2016-08-09 04:37:54 UTC) #11
calamity
https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/list_container.js File chrome/browser/resources/md_history/list_container.js (right): https://codereview.chromium.org/2207323002/diff/1/chrome/browser/resources/md_history/list_container.js#newcode88 chrome/browser/resources/md_history/list_container.js:88: this.$.content.selectedItem.unselectAllItems(count); On 2016/08/09 04:37:54, tsergeant wrote: > On 2016/08/09 ...
4 years, 4 months ago (2016-08-09 05:28:30 UTC) #13
tsergeant
lgtm % a few nits https://codereview.chromium.org/2207323002/diff/40001/chrome/test/data/webui/md_history/history_grouped_list_test.js File chrome/test/data/webui/md_history/history_grouped_list_test.js (right): https://codereview.chromium.org/2207323002/diff/40001/chrome/test/data/webui/md_history/history_grouped_list_test.js#newcode251 chrome/test/data/webui/md_history/history_grouped_list_test.js:251: assertEquals( On 2016/08/09 05:28:30, ...
4 years, 4 months ago (2016-08-09 23:20:00 UTC) #17
calamity
https://codereview.chromium.org/2207323002/diff/60001/chrome/browser/resources/md_history/compiled_resources2.gyp File chrome/browser/resources/md_history/compiled_resources2.gyp (right): https://codereview.chromium.org/2207323002/diff/60001/chrome/browser/resources/md_history/compiled_resources2.gyp#newcode53 chrome/browser/resources/md_history/compiled_resources2.gyp:53: 'browser_service', On 2016/08/09 23:20:00, tsergeant wrote: > Nit: I ...
4 years, 4 months ago (2016-08-10 04:25:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207323002/80001
4 years, 4 months ago (2016-08-10 04:26:24 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/119525)
4 years, 4 months ago (2016-08-10 05:52:25 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207323002/80001
4 years, 4 months ago (2016-08-11 02:53:39 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 4 months ago (2016-08-11 03:37:00 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 03:40:40 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1a7fa0b24d413123832e2707adbc0266122a225f
Cr-Commit-Position: refs/heads/master@{#411253}

Powered by Google App Engine
This is Rietveld 408576698