chrome/test/data/webui/md_history/history_item_test.js - Issue 2207323002: [MD History] Factor out a common HistoryListBehavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/md_history/history_item_test.js

Issue 2207323002: [MD History] Factor out a common HistoryListBehavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/md_history/history_grouped_list_test.js ('k') | chrome/test/data/webui/md_history/history_list_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/md_history/history_item_test.js

diff --git a/chrome/test/data/webui/md_history/history_item_test.js b/chrome/test/data/webui/md_history/history_item_test.js

index 94744a0d609bee67d0b00d58f0cfc8ffeb68196e..5d9bb83f90f1b6ccd1686deb25a0600ea028d7f3 100644

--- a/chrome/test/data/webui/md_history/history_item_test.js

+++ b/chrome/test/data/webui/md_history/history_item_test.js

@@ -63,13 +63,13 @@ cr.define('md_history.history_item_test', function() {

var items =

Polymer.dom(element.root).querySelectorAll('history-item');

- element.removeDeletedHistory_([element.historyData_[3]]);

+ element.removeItemsByPath(['historyData_.3']);

assertEquals(5, element.historyData_.length);

// Checks that a new time gap separator has been inserted.

assertTrue(items[2].hasTimeGap);

- element.removeDeletedHistory_([element.historyData_[3]]);

+ element.removeItemsByPath(['historyData_.3']);

// Checks time gap separator is removed.

assertFalse(items[2].hasTimeGap);