Use smart pointers for class owned pointers

Use smart pointers for class owned pointers

For classes under xfa/fgas, xfa/fwl/basewidget, and xfa/fwl/core,
use smart pointers instead of raw pointer to make memory management
easier.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/1b4f6b36b3ed8d1f6cea96bc32c1b376f4a499bc

[Wei Li, 2016-08-04 06:44:32]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 06:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 06:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 06:56:33]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-04 18:02:21]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-04 18:02:22]

pls review, thanks

[Lei Zhang, 2016-08-04 18:49:32]

lgtm

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/font/fgas_gefo...
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/font/fgas_gefo...
xfa/fgas/font/fgas_gefont.cpp:204: } else {
no else after return

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/layout/fgas_te...
File xfa/fgas/layout/fgas_textbreak.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/layout/fgas_te...
xfa/fgas/layout/fgas_textbreak.cpp:72: if (m_bPagination) {
int32_t iSize = m_bPagination ? sizeof(CFX_Char) : sizeof(CFX_TxtChar);
m_pTxtLine1.reset(new CFX_TxtLine(iSize));
m_pTxtLine2.reset(new CFX_TxtLine(iSize));

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/basewidget/cfx_...
File xfa/fwl/basewidget/cfx_barcode.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/basewidget/cfx_...
xfa/fwl/basewidget/cfx_barcode.cpp:329: return m_pBCEngine->Encode(contents,
isDevice, e);
return m_pBCEngine && m_pBCEngine->Foo();

here and below?

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:777: m_pToolTipDp->m_nInitDelayTime = 0;
Pass these into the CFWL_CoreToolTipDP ctor? The values set inside the
CFWL_CoreToolTipDP ctor seem useless.

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_widget...
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_widget...
xfa/fwl/core/fwl_widgetimp.cpp:543: m_pWidgetMgr =
CFWL_WidgetMgr::GetInstance();
Can this also go on the initializer list?

[Wei Li, 2016-08-04 22:14:47]

Patchset #3 (id:40001) has been deleted

[Wei Li, 2016-08-04 22:15:50]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[Wei Li, 2016-08-04 22:16:04]

thanks

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/font/fgas_gefo...
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/font/fgas_gefo...
xfa/fgas/font/fgas_gefont.cpp:204: } else {
On 2016/08/04 18:49:31, Lei Zhang wrote:
> no else after return

Done.

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/layout/fgas_te...
File xfa/fgas/layout/fgas_textbreak.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fgas/layout/fgas_te...
xfa/fgas/layout/fgas_textbreak.cpp:72: if (m_bPagination) {
On 2016/08/04 18:49:31, Lei Zhang wrote:
> int32_t iSize = m_bPagination ? sizeof(CFX_Char) : sizeof(CFX_TxtChar);
> m_pTxtLine1.reset(new CFX_TxtLine(iSize));
> m_pTxtLine2.reset(new CFX_TxtLine(iSize));

Done.

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/basewidget/cfx_...
File xfa/fwl/basewidget/cfx_barcode.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/basewidget/cfx_...
xfa/fwl/basewidget/cfx_barcode.cpp:329: return m_pBCEngine->Encode(contents,
isDevice, e);
On 2016/08/04 18:49:31, Lei Zhang wrote:
> return m_pBCEngine && m_pBCEngine->Foo();
> 
> here and below?

Done.

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:777: m_pToolTipDp->m_nInitDelayTime = 0;
On 2016/08/04 18:49:31, Lei Zhang wrote:
> Pass these into the CFWL_CoreToolTipDP ctor? The values set inside the
> CFWL_CoreToolTipDP ctor seem useless.

Done.

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_widget...
File xfa/fwl/core/fwl_widgetimp.cpp (right):

https://codereview.chromium.org/2207093005/diff/20001/xfa/fwl/core/fwl_widget...
xfa/fwl/core/fwl_widgetimp.cpp:543: m_pWidgetMgr =
CFWL_WidgetMgr::GetInstance();
On 2016/08/04 18:49:31, Lei Zhang wrote:
> Can this also go on the initializer list?

Done.

[commit-bot: I haz the power, 2016-08-04 22:16:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-04 22:19:31]

https://codereview.chromium.org/2207093005/diff/60001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2207093005/diff/60001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:676: CFWL_CoreToolTipDP::CFWL_CoreToolTipDP()
Is this ctor ever used? If yes, just use a Delegated Constructor and call the
one below.

[commit-bot: I haz the power, 2016-08-04 22:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:31:32]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-04 22:54:12]

thanks

https://codereview.chromium.org/2207093005/diff/60001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2207093005/diff/60001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:676: CFWL_CoreToolTipDP::CFWL_CoreToolTipDP()
On 2016/08/04 22:19:30, Lei Zhang wrote:
> Is this ctor ever used? If yes, just use a Delegated Constructor and call the
> one below.

It is not used in the code base. I thought maybe keeping it as a reference for
good default values. Well, we can always add it when we need it. Removed.

[Wei Li, 2016-08-04 22:54:34]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-04 22:56:34]

++lgtm

[commit-bot: I haz the power, 2016-08-04 23:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:32:53]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-04 23:37:25]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 23:37:50]

Description was changed from

==========
Use smart pointers for class owned pointers

For classes under xfa/fgas, xfa/fwl/basewidget, and xfa/fwl/core,
use smart pointers instead of raw pointer to make memory management
easier.

BUG=pdfium:518
==========

to

==========
Use smart pointers for class owned pointers

For classes under xfa/fgas, xfa/fwl/basewidget, and xfa/fwl/core,
use smart pointers instead of raw pointer to make memory management
easier.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/1b4f6b36b3ed8d1f6cea96bc32c1b376f4a4...
==========

[commit-bot: I haz the power, 2016-08-04 23:37:52]

Committed patchset #4 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/1b4f6b36b3ed8d1f6cea96bc32c1b376f4a4...