Use smart pointers for class owned pointers

xfa/fwl/core/fwl_widgetimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/fwl_widgetimp.h"
 
 #include <algorithm>
 
@@ skipping 513 matching lines @@
 void* CFWL_WidgetImp::GetAssociateWidget() const {
   return m_pAssociate;
 }
 
 void CFWL_WidgetImp::SetAssociateWidget(void* pAssociate) {
   m_pAssociate = pAssociate;
 }
 
 CFWL_WidgetImp::CFWL_WidgetImp(const CFWL_WidgetImpProperties& properties,
                                IFWL_Widget* pOuter)
-    : m_pProperties(new CFWL_WidgetImpProperties),
+    : m_pProperties(new CFWL_WidgetImpProperties(properties)),
       m_pDelegate(nullptr),
       m_pCurDelegate(nullptr),
       m_pOuter(pOuter),
       m_pInterface(nullptr),
       m_pLayoutItem(nullptr),
       m_pAssociate(nullptr),
       m_iLock(0),
       m_nEventKey(0) {
-  *m_pProperties = properties;
   m_pWidgetMgr = CFWL_WidgetMgr::GetInstance();

[Lei Zhang, 2016/08/04 18:49:31]

Can this also go on the initializer list?

[Wei Li, 2016/08/04 22:16:04]

Done.

   ASSERT(m_pWidgetMgr);
 }
 
-CFWL_WidgetImp::~CFWL_WidgetImp() {
-  delete m_pProperties;
-}
+CFWL_WidgetImp::~CFWL_WidgetImp() {}
 
 FX_BOOL CFWL_WidgetImp::IsEnabled() const {
   return (m_pProperties->m_dwStates & FWL_WGTSTATE_Disabled) == 0;
 }
 FX_BOOL CFWL_WidgetImp::IsVisible() const {
   return (m_pProperties->m_dwStates & FWL_WGTSTATE_Invisible) == 0;
 }
 FX_BOOL CFWL_WidgetImp::IsActive() const {
   return (m_pProperties->m_dwStates & FWL_WGTSTATE_Deactivated) == 0;
 }
@@ skipping 482 matching lines @@
   }
 }
 
 void CFWL_WidgetImpDelegate::OnProcessEvent(CFWL_Event* pEvent) {}
 
 void CFWL_WidgetImpDelegate::OnDrawWidget(CFX_Graphics* pGraphics,
                                           const CFX_Matrix* pMatrix) {
   CFWL_EvtDraw evt;
   evt.m_pGraphics = pGraphics;
 }