Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: sdk/lib/io/string_transformer.dart

Issue 22070003: convert: new LineSplitter, (io: Deprecate LineTransformer) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/string_transformer.dart
diff --git a/sdk/lib/io/string_transformer.dart b/sdk/lib/io/string_transformer.dart
index 4f18b99279965755fdd8656da6280cdfff999eff..bbdb1fb156525f6de528a46a99823570eb525872 100644
--- a/sdk/lib/io/string_transformer.dart
+++ b/sdk/lib/io/string_transformer.dart
@@ -259,63 +259,15 @@ List<int> _encodeString(String string, [Encoding encoding = Encoding.UTF_8]) {
return bytes;
}
+/**
+ * Use [LineSplitter] from `dart:convert` instead.
floitsch 2013/08/07 12:58:26 If you feel like it (if not I can do it later): Ad
kevmoo-old 2013/08/07 19:41:08 Not sure what to add to _collection_dev/iterable.d
+ */
+ @deprecated
+ class LineTransformer implements StreamTransformer<String, String> {
+ final _decoder = new LineSplitter();
-class LineTransformer extends StreamEventTransformer<String, String> {
- static const int _LF = 10;
- static const int _CR = 13;
-
- StringBuffer _buffer = new StringBuffer();
- String _carry;
-
- void _handle(String data, EventSink<String> sink, bool isClosing) {
- if (_carry != null) {
- data = _carry + data;
- _carry = null;
- }
- int startPos = 0;
- int pos = 0;
- while (pos < data.length) {
- int skip = 0;
- int char = data.codeUnitAt(pos);
- if (char == _LF) {
- skip = 1;
- } else if (char == _CR) {
- skip = 1;
- if (pos + 1 < data.length) {
- if (data.codeUnitAt(pos + 1) == _LF) {
- skip = 2;
- }
- } else if (!isClosing) {
- _carry = data.substring(startPos);
- return;
- }
- }
- if (skip > 0) {
- _buffer.write(data.substring(startPos, pos));
- sink.add(_buffer.toString());
- _buffer = new StringBuffer();
- startPos = pos = pos + skip;
- } else {
- pos++;
- }
- }
- if (pos != startPos) {
- // Add remaining
- _buffer.write(data.substring(startPos, pos));
- }
- if (isClosing && !_buffer.isEmpty) {
- sink.add(_buffer.toString());
- _buffer = new StringBuffer();
- }
- }
-
- void handleData(String data, EventSink<String> sink) {
- _handle(data, sink, false);
- }
-
- void handleDone(EventSink<String> sink) {
- _handle("", sink, true);
- sink.close();
+ Stream<String> bind(Stream<String> stream) {
+ return _decoder.bind(stream);
}
}

Powered by Google App Engine
This is Rietveld 408576698