convert: new LineSplitter, (io: Deprecate LineTransformer)

sdk/lib/io/string_transformer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 /**
  * String encodings.
  */
 class Encoding {
@@ skipping 241 matching lines @@
   var controller = new StreamController(sync: true);
   controller.stream
     .transform(new StringEncoder(encoding))
     .listen((data) => bytes = data);
   controller.add(string);
   controller.close();
   assert(bytes != null);
   return bytes;
 }
 
+/**
+ * Use [LineSplitter] from `dart:convert` instead.

[floitsch, 2013/08/07 12:58:26]

If you feel like it (if not I can do it later):
Add removal date, let's say 3 weeks from now.
Add it in comment, and update the comment in the internal _collection_dev
library (sdk/lib/_collection_dev/iterable.dart). Reassign TODO there to me.

[kevmoo-old, 2013/08/07 19:41:08]

Not sure what to add to _collection_dev/iterable.dart. Help?

+ */
+ @deprecated
+ class LineTransformer implements StreamTransformer<String, String> {
+  final _decoder = new LineSplitter();
 
-class LineTransformer extends StreamEventTransformer<String, String> {
-  static const int _LF = 10;
-  static const int _CR = 13;
-
-  StringBuffer _buffer = new StringBuffer();
-  String _carry;
-
-  void _handle(String data, EventSink<String> sink, bool isClosing) {
-    if (_carry != null) {
-      data = _carry + data;
-      _carry = null;
-    }
-    int startPos = 0;
-    int pos = 0;
-    while (pos < data.length) {
-      int skip = 0;
-      int char = data.codeUnitAt(pos);
-      if (char == _LF) {
-        skip = 1;
-      } else if (char == _CR) {
-        skip = 1;
-        if (pos + 1 < data.length) {
-          if (data.codeUnitAt(pos + 1) == _LF) {
-            skip = 2;
-          }
-        } else if (!isClosing) {
-          _carry = data.substring(startPos);
-          return;
-        }
-      }
-      if (skip > 0) {
-        _buffer.write(data.substring(startPos, pos));
-        sink.add(_buffer.toString());
-        _buffer = new StringBuffer();
-        startPos = pos = pos + skip;
-      } else {
-        pos++;
-      }
-    }
-    if (pos != startPos) {
-      // Add remaining
-      _buffer.write(data.substring(startPos, pos));
-    }
-    if (isClosing && !_buffer.isEmpty) {
-      sink.add(_buffer.toString());
-      _buffer = new StringBuffer();
-    }
-  }
-
-  void handleData(String data, EventSink<String> sink) {
-    _handle(data, sink, false);
-  }
-
-  void handleDone(EventSink<String> sink) {
-    _handle("", sink, true);
-    sink.close();
+  Stream<String> bind(Stream<String> stream) {
+    return _decoder.bind(stream);
   }
 }
 
 
 abstract class _SingleByteDecoder
     extends StreamEventTransformer<List<int>, String> {
   final int _replacementChar;
 
   _SingleByteDecoder(this._replacementChar);
 
@@ skipping 82 matching lines @@
 
 // Utility class for decoding Windows current code page data delivered
 // as a stream of bytes.
 class _WindowsCodePageDecoder extends StreamEventTransformer<List<int>, String> {
   void handleData(List<int> data, EventSink<String> sink) {
     sink.add(_decodeBytes(data));
   }
 
   external static String _decodeBytes(List<int> bytes);
 }