Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2206943002: [inspector] fix GYP/MSVS build warnings. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fix GYP/MSVS build warnings. R=machenbach@chromium.org Committed: https://crrev.com/25c0501c8f4cc1b4d6dcfb0da42bb99283dc3575 Cr-Commit-Position: refs/heads/master@{#38278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/inspector/inspector.gyp View 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Yang
4 years, 4 months ago (2016-08-03 06:58:50 UTC) #1
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-03 07:05:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206943002/1
4 years, 4 months ago (2016-08-03 07:20:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 07:44:47 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 07:47:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25c0501c8f4cc1b4d6dcfb0da42bb99283dc3575
Cr-Commit-Position: refs/heads/master@{#38278}

Powered by Google App Engine
This is Rietveld 408576698