Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2206983002: [inspector] suppress build warnings on windows/clang (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Nico, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@inspector_msvs_warnings
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] suppress build warnings on windows/clang R=machenbach@chromium.org,thakis@chromium.org BUG=v8:5258 Committed: https://crrev.com/b96823ff2922d1821200899dbef011e8df51d9e2 Cr-Commit-Position: refs/heads/master@{#38343}

Patch Set 1 #

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gypfiles/standalone.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Yang
4 years, 4 months ago (2016-08-03 10:52:11 UTC) #1
Nico
I don't think that's the right place. This is wrong for every single file that ...
4 years, 4 months ago (2016-08-03 13:55:12 UTC) #2
Yang
On 2016/08/03 13:55:12, Nico wrote: > I don't think that's the right place. This is ...
4 years, 4 months ago (2016-08-04 07:12:56 UTC) #3
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-04 07:18:57 UTC) #4
Nico
lgtm
4 years, 4 months ago (2016-08-04 15:05:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206983002/20001
4 years, 4 months ago (2016-08-04 15:22:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 15:39:59 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 15:43:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b96823ff2922d1821200899dbef011e8df51d9e2
Cr-Commit-Position: refs/heads/master@{#38343}

Powered by Google App Engine
This is Rietveld 408576698