Move clang_version setting back into declare_args

Move clang_version setting back into declare_args

This allows the user to indicate that their clang version is something
other than the default. Right now we guess 3.9.0 for the clang version,
but TOT LLVM is on version 4.0.0.

I use this to test changes to the ASan runtime in Chrome.

R=hans@chromium.org,etienneb@chromium.org,dpranke@chromium.org
BUG=598761
Committed: https://crrev.com/4a42af48e74062a70c97ae54438218fbb23ecd53
Cr-Commit-Position: refs/heads/master@{#409414}

[hans, 2016-08-02 23:47:46]

When I changed it, I couldn't think of a reason one would need to override this,
but I guess we've now found one :-)

lgtm

[Dirk Pranke, 2016-08-02 23:59:00]

lgtm w/ suggested change.

https://codereview.chromium.org/2206803002/diff/1/build/toolchain/toolchain.gni
File build/toolchain/toolchain.gni (right):

https://codereview.chromium.org/2206803002/diff/1/build/toolchain/toolchain.g...
build/toolchain/toolchain.gni:46: }
Can you move this all into a separate declare_args() block? I'm not sure if
this'll actually work correctly as written, because I think the
llvm_force_head_revision=true in your args.gn won't take effect until the end of
the first declare_args() block.

[Reid Kleckner, 2016-08-03 00:02:58]

separate declare_args()

[Reid Kleckner, 2016-08-03 00:03:30]

https://codereview.chromium.org/2206803002/diff/1/build/toolchain/toolchain.gni
File build/toolchain/toolchain.gni (right):

https://codereview.chromium.org/2206803002/diff/1/build/toolchain/toolchain.g...
build/toolchain/toolchain.gni:46: }
On 2016/08/02 23:58:59, Dirk Pranke wrote:
> Can you move this all into a separate declare_args() block? I'm not sure if
> this'll actually work correctly as written, because I think the
> llvm_force_head_revision=true in your args.gn won't take effect until the end
of
> the first declare_args() block.

Thanks! We probably wouldn't have caught that until it hit the clang TOT
waterfall if that's really how it works.

[Reid Kleckner, 2016-08-03 00:03:33]

The CQ bit was checked by rnk@chromium.org

[Reid Kleckner, 2016-08-03 00:03:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, hans@chromium.org
Link to the patchset: https://codereview.chromium.org/2206803002/#ps20001
(title: "separate declare_args()")

[commit-bot: I haz the power, 2016-08-03 00:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 01:20:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 01:21:46]

Description was changed from

==========
Move clang_version setting back into declare_args

This allows the user to indicate that their clang version is something
other than the default. Right now we guess 3.9.0 for the clang version,
but TOT LLVM is on version 4.0.0.

I use this to test changes to the ASan runtime in Chrome.

R=hans@chromium.org,etienneb@chromium.org,dpranke@chromium.org
BUG=598761
==========

to

==========
Move clang_version setting back into declare_args

This allows the user to indicate that their clang version is something
other than the default. Right now we guess 3.9.0 for the clang version,
but TOT LLVM is on version 4.0.0.

I use this to test changes to the ASan runtime in Chrome.

R=hans@chromium.org,etienneb@chromium.org,dpranke@chromium.org
BUG=598761

Committed: https://crrev.com/4a42af48e74062a70c97ae54438218fbb23ecd53
Cr-Commit-Position: refs/heads/master@{#409414}
==========

[commit-bot: I haz the power, 2016-08-03 01:21:47]

Patchset 2 (id:??) landed as
https://crrev.com/4a42af48e74062a70c97ae54438218fbb23ecd53
Cr-Commit-Position: refs/heads/master@{#409414}