Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: build/toolchain/toolchain.gni

Issue 2206803002: Move clang_version setting back into declare_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: separate declare_args() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Toolchain-related configuration that may be needed outside the context of the 5 # Toolchain-related configuration that may be needed outside the context of the
6 # toolchain() rules themselves. 6 # toolchain() rules themselves.
7 7
8 import("//build/config/chrome_build.gni") 8 import("//build/config/chrome_build.gni")
9 9
10 declare_args() { 10 declare_args() {
(...skipping 18 matching lines...) Expand all
29 # conjunction with setting LLVM_FORCE_HEAD_REVISION in the 29 # conjunction with setting LLVM_FORCE_HEAD_REVISION in the
30 # environment when `gclient runhooks` is run as well. 30 # environment when `gclient runhooks` is run as well.
31 llvm_force_head_revision = false 31 llvm_force_head_revision = false
32 32
33 # Compile with Xcode version of clang instead of hermetic version shipped 33 # Compile with Xcode version of clang instead of hermetic version shipped
34 # with the build. Used on iOS to ship official builds (as they are built 34 # with the build. Used on iOS to ship official builds (as they are built
35 # with the version of clang shipped with Xcode). 35 # with the version of clang shipped with Xcode).
36 use_xcode_clang = is_ios && is_official_build 36 use_xcode_clang = is_ios && is_official_build
37 } 37 }
38 38
39 if (is_clang) { 39 declare_args() {
40 # Clang compiler version. Clang files are placed at version-dependent paths. 40 if (is_clang) {
41 clang_version = "3.9.0" 41 # Clang compiler version. Clang files are placed at version-dependent paths.
42 clang_version = "3.9.0"
42 43
43 if (llvm_force_head_revision) { 44 if (llvm_force_head_revision) {
44 # TODO(hans): Remove after next Clang roll. 45 # TODO(hans): Remove after next Clang roll.
45 # ToT Clang has a higher version number. 46 # ToT Clang has a higher version number.
46 clang_version = "4.0.0" 47 clang_version = "4.0.0"
48 }
47 } 49 }
48 } 50 }
49 51
50 assert(!use_xcode_clang || is_ios, 52 assert(!use_xcode_clang || is_ios,
51 "Using Xcode's clang is only supported in iOS builds") 53 "Using Xcode's clang is only supported in iOS builds")
52 54
53 # Subdirectory within root_out_dir for shared library files. 55 # Subdirectory within root_out_dir for shared library files.
54 # TODO(agrieve): GYP sets this to "lib" for Linux & Android, but this won't work 56 # TODO(agrieve): GYP sets this to "lib" for Linux & Android, but this won't work
55 # in GN until support for loadable_module() is added. 57 # in GN until support for loadable_module() is added.
56 # See: https://codereview.chromium.org/1236503002/ 58 # See: https://codereview.chromium.org/1236503002/
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 stamp_description = "STAMP {{output}}" 95 stamp_description = "STAMP {{output}}"
94 copy_description = "COPY {{source}} {{output}}" 96 copy_description = "COPY {{source}} {{output}}"
95 if (host_os == "win") { 97 if (host_os == "win") {
96 stamp_command = "$python_path gyp-win-tool stamp {{output}}" 98 stamp_command = "$python_path gyp-win-tool stamp {{output}}"
97 copy_command = 99 copy_command =
98 "$python_path gyp-win-tool recursive-mirror {{source}} {{output}}" 100 "$python_path gyp-win-tool recursive-mirror {{source}} {{output}}"
99 } else { 101 } else {
100 stamp_command = "touch {{output}}" 102 stamp_command = "touch {{output}}"
101 copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})" 103 copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})"
102 } 104 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698