Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 2206793004: Revert of Add grid/flex layout support for <fieldset> (Closed)

Created:
4 years, 4 months ago by inferno
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add grid/flex layout support for <fieldset> (patchset #10 id:290001 of https://codereview.chromium.org/2150003005/ ) Reason for revert: Causing use-after-frees on ClusterFuzz. Original issue's description: > Add grid/flex layout support for <fieldset> > > This adds grid/flex layout support for <fieldset> by > introducing an anonymous inner block that is used to > layout fieldset's underlying blocks without interfering > with the special paint flow used to render <legend> > element. > > W3C/CSS WG discussion: > https://github.com/w3c/csswg-drafts/issues/321 > > Testing: > - All affected tests' results were verified to make sure > that there are no differences in pixel test results between > old and new version of LayoutFieldSet. > - 2 more tests were added > (fieldset-display-{flex|grid}.html) > - verified interoperability of fieldset(display: flex) > with Firefox(one of 2 browsers that support fieldset's flex > layout) > > BUG=262679, 375693 > TEST=fast/forms/fieldset/fieldset-display-flex.html; > fast/forms/fieldset/fieldset-display-grid.html > > Committed: https://crrev.com/c6d69f896f406c9a7801b29cb8c02a88e5b01770 > Cr-Commit-Position: refs/heads/master@{#409303} TBR=dmazzoni@chromium.org,aboxhall@chromium.org,cbiesinger@chromium.org,glebl@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=262679, 375693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -465 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex-expected.html View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 4 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.h View 2 chunks +7 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 5 chunks +12 lines, -136 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
inferno
Created Revert of Add grid/flex layout support for <fieldset>
4 years, 4 months ago (2016-08-03 20:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206793004/1
4 years, 4 months ago (2016-08-03 20:29:16 UTC) #3
cbiesinger
On 2016/08/03 20:28:40, inferno wrote: > Created Revert of Add grid/flex layout support for <fieldset> ...
4 years, 4 months ago (2016-08-03 20:29:26 UTC) #4
aarya
On 2016/08/03 20:29:26, cbiesinger wrote: > On 2016/08/03 20:28:40, inferno wrote: > > Created Revert ...
4 years, 4 months ago (2016-08-03 20:29:59 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:32:18 UTC) #7
Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698