Chromium Code Reviews
DescriptionRevert of Make chromium_trybots always run layout tests on tryserver.blink bots. (patchset #1 id:1 of https://codereview.chromium.org/2194553002/ )
Reason for revert:
After http://crbug.com/2195223002, layout tests are not filtered out of the test list for Blink try jobs, so there's no need to add Blink tests again.
See http://crbug.com/634104.
Original issue's description:
> Make chromium_trybots always run layout tests on tryserver.blink bots.
>
> Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
> simulation expectation files include more tests. The webkit_tests
> was in the simulation expectation files for the other blink try bots
> because "suppress_analyze" was in the test, but that wasn't in the
> step for use_{skia,v8}_patch_on_blink_trybot.
>
> Pros:
> - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng builders
>
> Cons
> - This would not make the new
> linux_layout_tests_slimming_paint_v2 bot work as it should.
> - This results in running some blink-related tests that may not be necessary depending on the CL
>
> This is one alternative to http://crrev.com/2190163003.
>
> BUG=631014
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/f0cf894af9bbfc9eec5e1237088ea790d25d3008
TBR=dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=631014
Committed: https://chromium.googlesource.com/chromium/tools/build/+/051348e7c052a488bc021506501dd1da231b12d5
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||||||||||||||||||||