Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2206763003: Revert of Make chromium_trybots always run layout tests on tryserver.blink bots. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Make chromium_trybots always run layout tests on tryserver.blink bots. (patchset #1 id:1 of https://codereview.chromium.org/2194553002/ ) Reason for revert: After http://crbug.com/2195223002, layout tests are not filtered out of the test list for Blink try jobs, so there's no need to add Blink tests again. See http://crbug.com/634104. Original issue's description: > Make chromium_trybots always run layout tests on tryserver.blink bots. > > Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot > simulation expectation files include more tests. The webkit_tests > was in the simulation expectation files for the other blink try bots > because "suppress_analyze" was in the test, but that wasn't in the > step for use_{skia,v8}_patch_on_blink_trybot. > > Pros: > - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng builders > > Cons > - This would not make the new > linux_layout_tests_slimming_paint_v2 bot work as it should. > - This results in running some blink-related tests that may not be necessary depending on the CL > > This is one alternative to http://crrev.com/2190163003. > > BUG=631014 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/f0cf894af9bbfc9eec5e1237088ea790d25d3008 TBR=dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=631014 Committed: https://chromium.googlesource.com/chromium/tools/build/+/051348e7c052a488bc021506501dd1da231b12d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -462 lines) Patch
M scripts/slave/recipes/chromium_trybot.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json View 3 chunks +2 lines, -230 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json View 3 chunks +2 lines, -230 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
Created Revert of Make chromium_trybots always run layout tests on tryserver.blink bots.
4 years, 4 months ago (2016-08-03 21:39:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206763003/1
4 years, 4 months ago (2016-08-03 21:39:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/051348e7c052a488bc021506501dd1da231b12d5
4 years, 4 months ago (2016-08-03 21:46:37 UTC) #7
Dirk Pranke
4 years, 4 months ago (2016-08-03 22:07:59 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698