Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: scripts/slave/recipes/chromium_trybot.py

Issue 2206763003: Revert of Make chromium_trybots always run layout tests on tryserver.blink bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import collections 5 import collections
6 6
7 from recipe_engine.types import freeze 7 from recipe_engine.types import freeze
8 8
9 DEPS = [ 9 DEPS = [
10 'depot_tools/bot_update', 10 'depot_tools/bot_update',
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 if affects_blink: 141 if affects_blink:
142 subproject_tag = 'blink' 142 subproject_tag = 'blink'
143 elif affects_blink_paths: 143 elif affects_blink_paths:
144 subproject_tag = 'blink-paths' 144 subproject_tag = 'blink-paths'
145 else: 145 else:
146 subproject_tag = 'chromium' 146 subproject_tag = 'chromium'
147 api.tryserver.set_subproject_tag(subproject_tag) 147 api.tryserver.set_subproject_tag(subproject_tag)
148 148
149 # TODO(phajdan.jr): Remove special case for layout tests. 149 # TODO(phajdan.jr): Remove special case for layout tests.
150 add_blink_tests = (affects_blink_paths and 150 add_blink_tests = (affects_blink_paths and
151 (buildername in CHROMIUM_BLINK_TESTS_BUILDERS or 151 buildername in CHROMIUM_BLINK_TESTS_BUILDERS)
152 mastername == 'tryserver.blink'))
153 152
154 # Add blink tests that work well with "analyze" here. The tricky ones 153 # Add blink tests that work well with "analyze" here. The tricky ones
155 # that bypass it (like the layout tests) are added later. 154 # that bypass it (like the layout tests) are added later.
156 if add_blink_tests: 155 if add_blink_tests:
157 add_tests([ 156 add_tests([
158 api.chromium_tests.steps.GTestTest('blink_heap_unittests'), 157 api.chromium_tests.steps.GTestTest('blink_heap_unittests'),
159 api.chromium_tests.steps.GTestTest('blink_platform_unittests'), 158 api.chromium_tests.steps.GTestTest('blink_platform_unittests'),
160 api.chromium_tests.steps.GTestTest('webkit_unit_tests'), 159 api.chromium_tests.steps.GTestTest('webkit_unit_tests'),
161 api.chromium_tests.steps.GTestTest('wtf_unittests'), 160 api.chromium_tests.steps.GTestTest('wtf_unittests'),
162 ]) 161 ])
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 props(mastername='tryserver.v8', 932 props(mastername='tryserver.v8',
934 buildername='v8_linux_blink_rel', 933 buildername='v8_linux_blink_rel',
935 patch_project='v8') + 934 patch_project='v8') +
936 api.platform.name('linux') + 935 api.platform.name('linux') +
937 suppress_analyze(more_exclusions=['v8/f.*']) + 936 suppress_analyze(more_exclusions=['v8/f.*']) +
938 api.override_step_data('webkit_tests (with patch)', 937 api.override_step_data('webkit_tests (with patch)',
939 api.test_utils.canned_test_output(passing=False)) + 938 api.test_utils.canned_test_output(passing=False)) +
940 api.override_step_data('webkit_tests (without patch)', 939 api.override_step_data('webkit_tests (without patch)',
941 api.test_utils.canned_test_output(passing=True, minimal=True)) 940 api.test_utils.canned_test_output(passing=True, minimal=True))
942 ) 941 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698