chrome/browser/extensions/extension_message_bubble_controller.h - Issue 2206693002: Improve settings override bubble to indicate policy installed extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller.h

Issue 2206693002: Improve settings override bubble to indicate policy installed extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed path 4 code review; initial attempt to remove "Restore Settings" button Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/dev_mode_bubble_delegate.cc ('k') | chrome/browser/extensions/ntp_overridden_bubble_delegate.h » ('j') | chrome/browser/ui/extensions/extension_message_bubble_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_bubble_controller.h

diff --git a/chrome/browser/extensions/extension_message_bubble_controller.h b/chrome/browser/extensions/extension_message_bubble_controller.h

index 2af76e9781686dc06213f339c6ab91ade1e5d646..1183de18c1ee57e23985c299317dc9e56940ba5c 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller.h

+++ b/chrome/browser/extensions/extension_message_bubble_controller.h

@@ -87,6 +87,11 @@ class ExtensionMessageBubbleController : public chrome::BrowserListObserver {

// state specific to the type (e.g., shown for profiles).

virtual const char* GetKey() = 0;

+ // Returns true if the extension is of a type that can be policy installed.

Devlin 2016/09/12 22:51:43 nit: not if the extension is of type, but rather i

catmullings 2016/09/22 00:00:10 Done.

+ // E.g. A proxy-type extension can be policy installed, but a developer-type

+ // extension cannot.

+ virtual bool SupportsPolicyIndicator() = 0;

// Whether the "shown for profiles" set should be cleared if an action is

// taken on the bubble. This defaults to true, since once an action is

// taken, the extension will usually either be acknowledged or removed, and