Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/extensions/extension_message_bubble_controller.h

Issue 2206693002: Improve settings override bubble to indicate policy installed extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed path 4 code review; initial attempt to remove "Restore Settings" button Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 virtual bool ShouldLimitToEnabledExtensions() const = 0; 80 virtual bool ShouldLimitToEnabledExtensions() const = 0;
81 81
82 // Record, through UMA, how many extensions were found. 82 // Record, through UMA, how many extensions were found.
83 virtual void LogExtensionCount(size_t count) = 0; 83 virtual void LogExtensionCount(size_t count) = 0;
84 virtual void LogAction(BubbleAction action) = 0; 84 virtual void LogAction(BubbleAction action) = 0;
85 85
86 // Returns a key unique to the type of bubble that can be used to retrieve 86 // Returns a key unique to the type of bubble that can be used to retrieve
87 // state specific to the type (e.g., shown for profiles). 87 // state specific to the type (e.g., shown for profiles).
88 virtual const char* GetKey() = 0; 88 virtual const char* GetKey() = 0;
89 89
90 // Returns true if the extension is of a type that can be policy installed.
Devlin 2016/09/12 22:51:43 nit: not if the extension is of type, but rather i
catmullings 2016/09/22 00:00:10 Done.
91 // E.g. A proxy-type extension can be policy installed, but a developer-type
92 // extension cannot.
93 virtual bool SupportsPolicyIndicator() = 0;
94
90 // Whether the "shown for profiles" set should be cleared if an action is 95 // Whether the "shown for profiles" set should be cleared if an action is
91 // taken on the bubble. This defaults to true, since once an action is 96 // taken on the bubble. This defaults to true, since once an action is
92 // taken, the extension will usually either be acknowledged or removed, and 97 // taken, the extension will usually either be acknowledged or removed, and
93 // the bubble won't show for that extension. 98 // the bubble won't show for that extension.
94 // This should be false in cases where there is no acknowledgment option 99 // This should be false in cases where there is no acknowledgment option
95 // (as in the developer-mode extension warning). 100 // (as in the developer-mode extension warning).
96 virtual bool ClearProfileSetAfterAction(); 101 virtual bool ClearProfileSetAfterAction();
97 102
98 // Has the user acknowledged info about the extension the bubble reports. 103 // Has the user acknowledged info about the extension the bubble reports.
99 bool HasBubbleInfoBeenAcknowledged(const std::string& extension_id); 104 bool HasBubbleInfoBeenAcknowledged(const std::string& extension_id);
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 bool is_active_bubble_; 214 bool is_active_bubble_;
210 215
211 ScopedObserver<BrowserList, BrowserListObserver> browser_list_observer_; 216 ScopedObserver<BrowserList, BrowserListObserver> browser_list_observer_;
212 217
213 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController); 218 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController);
214 }; 219 };
215 220
216 } // namespace extensions 221 } // namespace extensions
217 222
218 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 223 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698