Improve settings override bubble to indicate policy installed extensions

chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h

Index: chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h b/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
index 1b75dbeac845eb46e9f9679e6d6e513d20f3bf86..1b7e821d9fee8012066e4d7256436283d0f70044 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/strings/string16.h"
+#include "ui/views/controls/image_view.h"

[Devlin, 2016/08/02 20:34:05]

This is a layering violation, since this class is used on all platforms.  The
views-specific implementation needs to only be in files in c/b/ui/views/.

[catmullings, 2016/08/13 00:35:52]

Done.

 
 // A delegate for a generic bubble that hangs off the toolbar actions bar.
 class ToolbarActionsBarBubbleDelegate {
@@ -19,6 +20,12 @@ class ToolbarActionsBarBubbleDelegate {
     CLOSE_DISMISS_DEACTIVATION,
   };
 
+  struct ExtraViewInfo {

[Devlin, 2016/08/02 20:34:06]

Document this struct and its fields.

[catmullings, 2016/08/13 00:35:52]

Done.

+    views::ImageView* icon;

[Devlin, 2016/08/02 20:34:06]

So instead of ImageView here, we'd want to use a gfx::Image or int resource_id.

[catmullings, 2016/08/13 00:35:52]

Done.

+    base::string16 text;
+    bool is_clickable;
+  };
+
   virtual ~ToolbarActionsBarBubbleDelegate() {}
 
   // Returns true if the bubble should (still) be shown. Since bubbles are
@@ -64,6 +71,8 @@ class ToolbarActionsBarBubbleDelegate {
 
   // Called when the bubble is closed with the type of action the user took.
   virtual void OnBubbleClosed(CloseAction action) = 0;
+
+  virtual std::unique_ptr<ExtraViewInfo> GetExtraViewInfo() = 0;

[Devlin, 2016/08/02 20:34:05]

Add a comment explaining this method.

[catmullings, 2016/08/13 00:35:52]

Done.

 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_