Improve settings override bubble to indicate policy installed extensions

chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_
 #define CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_
 
 #include <string>
 
 #include "base/strings/string16.h"
+#include "ui/views/controls/image_view.h"

[Devlin, 2016/08/02 20:34:05]

This is a layering violation, since this class is used on all platforms.  The
views-specific implementation needs to only be in files in c/b/ui/views/.

[catmullings, 2016/08/13 00:35:52]

Done.

 
 // A delegate for a generic bubble that hangs off the toolbar actions bar.
 class ToolbarActionsBarBubbleDelegate {
  public:
   enum CloseAction {
     CLOSE_LEARN_MORE,
     CLOSE_EXECUTE,
     CLOSE_DISMISS_USER_ACTION,
     CLOSE_DISMISS_DEACTIVATION,
   };
 
+  struct ExtraViewInfo {

[Devlin, 2016/08/02 20:34:06]

Document this struct and its fields.

[catmullings, 2016/08/13 00:35:52]

Done.

+    views::ImageView* icon;

[Devlin, 2016/08/02 20:34:06]

So instead of ImageView here, we'd want to use a gfx::Image or int resource_id.

[catmullings, 2016/08/13 00:35:52]

Done.

+    base::string16 text;
+    bool is_clickable;
+  };
+
   virtual ~ToolbarActionsBarBubbleDelegate() {}
 
   // Returns true if the bubble should (still) be shown. Since bubbles are
   // sometimes shown asynchronously, they may be invalid by the time they would
   // be displayed.
   virtual bool ShouldShow() = 0;
 
   // Returns true if the bubble should close on deactivation.
   virtual bool ShouldCloseOnDeactivate() = 0;
 
@@ skipping 25 matching lines @@
 
   // Returns the id of the action to point to, or the empty string if the
   // bubble should point to the center of the actions container.
   virtual std::string GetAnchorActionId() = 0;
 
   // Called when the bubble is shown.
   virtual void OnBubbleShown() = 0;
 
   // Called when the bubble is closed with the type of action the user took.
   virtual void OnBubbleClosed(CloseAction action) = 0;
+
+  virtual std::unique_ptr<ExtraViewInfo> GetExtraViewInfo() = 0;

[Devlin, 2016/08/02 20:34:05]

Add a comment explaining this method.

[catmullings, 2016/08/13 00:35:52]

Done.

 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_