tools/skdiff_utils.h - Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skdiff_utils.h

Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Gotta catch 'em all. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skdiff_utils.h

diff --git a/tools/skdiff_utils.h b/tools/skdiff_utils.h

index ae7d51a1d2ce765f950f781d40ff73c6e1b5c048..c535ae26b58ded4845d2a01b26dd6c015d298375 100644

--- a/tools/skdiff_utils.h

+++ b/tools/skdiff_utils.h

@@ -22,7 +22,7 @@ bool are_buffers_equal(SkData* skdata1, SkData* skdata2);

/** Reads the file at the given path and returns its complete contents as an

* SkData object (or returns nullptr on error).

-SkData* read_file(const char* file_path);

+sk_sp<SkData> read_file(const char* file_path);

/** Decodes the fileBits into the resource.fBitmap. Returns false on failure. */

bool get_bitmap(SkData* fileBits, DiffResource& resource, bool sizeOnly);