[TTS] Update the Tap Event Test to support Translations.

[TTS] Update the Tap Event Test to support Translations.

Updates our mock-test infrastructure in ContextualSearchTapEventTest to
have a new mock for the ContextualSearchTranslateController that mocks
calls to the native ContextualSearchManager (which does not exist in the
mock environment).

This allows enabling translation in our waterfall tests.
Still TODO -- adding more tests for Translation.

BUG=633407
Committed: https://crrev.com/a9784b5a19baf40450cb710d752b688f1fb9feef
Cr-Commit-Position: refs/heads/master@{#409372}

[Donn Denman, 2016-08-02 18:07:42]

donnd@chromium.org changed reviewers:
+ mdjones@chromium.org

[Donn Denman, 2016-08-02 18:07:42]

Matt, PTAL.  Thanks!

[mdjones, 2016-08-02 20:09:22]

https://codereview.chromium.org/2206613002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2206613002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:95:

Can this just be protected to avoid adding another setter?

https://codereview.chromium.org/2206613002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
(right):

https://codereview.chromium.org/2206613002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java:216:
MockContextualSearchPolicy policy = new
MockContextualSearchPolicy(getActivity());
Since this is a local var, can we just move this into the constructor for
ContextualSearchManagerWrapper?

mTranslateController = new MockContextualSearch...

[Donn Denman, 2016-08-02 21:42:56]

Thanks Matt, PTAL.

https://codereview.chromium.org/2206613002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2206613002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:95:

On 2016/08/02 20:09:22, mdjones wrote:
> Can this just be protected to avoid adding another setter?

Done.

https://codereview.chromium.org/2206613002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
(right):

https://codereview.chromium.org/2206613002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java:216:
MockContextualSearchPolicy policy = new
MockContextualSearchPolicy(getActivity());
On 2016/08/02 20:09:22, mdjones wrote:
> Since this is a local var, can we just move this into the constructor for
> ContextualSearchManagerWrapper?
> 
> mTranslateController = new MockContextualSearch...

Done.

[mdjones, 2016-08-02 21:48:57]

lgtm

[Donn Denman, 2016-08-02 21:54:15]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:54:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 23:12:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 23:14:47]

Description was changed from

==========
[TTS] Update the Tap Event Test to support Translations.

Updates our mock-test infrastructure in ContextualSearchTapEventTest to
have a new mock for the ContextualSearchTranslateController that mocks
calls to the native ContextualSearchManager (which does not exist in the
mock environment).

This allows enabling translation in our waterfall tests.
Still TODO -- adding more tests for Translation.

BUG=633407
==========

to

==========
[TTS] Update the Tap Event Test to support Translations.

Updates our mock-test infrastructure in ContextualSearchTapEventTest to
have a new mock for the ContextualSearchTranslateController that mocks
calls to the native ContextualSearchManager (which does not exist in the
mock environment).

This allows enabling translation in our waterfall tests.
Still TODO -- adding more tests for Translation.

BUG=633407

Committed: https://crrev.com/a9784b5a19baf40450cb710d752b688f1fb9feef
Cr-Commit-Position: refs/heads/master@{#409372}
==========

[commit-bot: I haz the power, 2016-08-02 23:14:48]

Patchset 2 (id:??) landed as
https://crrev.com/a9784b5a19baf40450cb710d752b688f1fb9feef
Cr-Commit-Position: refs/heads/master@{#409372}